From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 27895-done@debbugs.gnu.org
Subject: bug#27895: 26.0.50; display-line-numbers and header-line-format alignment
Date: Sun, 6 Aug 2017 16:25:43 -0400 [thread overview]
Message-ID: <20170806202543.GA1853@holos.localdomain> (raw)
In-Reply-To: <83y3qyuujc.fsf@gnu.org>
On 05/08/17 at 02:24pm, Eli Zaretskii wrote:
>> > From: Mark Oteiza <mvoteiza@udel.edu>
>> > Date: Mon, 31 Jul 2017 21:35:48 -0400
>> >
>> > Enabling display-line-numbers should affect how header-line-format is
>> > shown.
>>
>> I'm not sure I agree with this, not in this general form. Modes use
>> header-line in different ways, and I don't think we can decide for all
>> of them up front how they should react to line numbers.
>>
>> While I agree that tabulated-list modes and ruler-mode should indeed
>> be sensitive to line numbers, because the header-line in those modes
>> should align with the rest of buffer text, a counter-example is Info
>> mode, where indenting the header-line will IMO make the display look
>> uglier, almost buggy.
>>
>> If people agree that the effect on header-line should be dependent on
>> the mode, then it follows that the fix should be in the modes, not in
>> the display engine. Fixing tabulated-list-mode will fix all of its
>> descendants; ruler-mode will need a separate fix. And likewise for
>> any other mode which reports a similar issue.
>
>No further comments, so I've fixed tabulated-list-mode and ruler-mode
>to be sensitive to display-line-numbers, and I'm boldly marking this
>bug done.
Thanks. Info mode being an exception is fine I suppose, though I don't
agree that it would look buggy.
However, from -Q:
1. C-x C-b
2. M-x global-display-line-numbers-mode
The header line does not change until one does a revert-buffer in the
buffer list. This doesn't look good to me.
next prev parent reply other threads:[~2017-08-06 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 1:35 bug#27895: 26.0.50; display-line-numbers and header-line-format alignment Mark Oteiza
2017-08-01 3:35 ` Eli Zaretskii
2017-08-05 11:24 ` Eli Zaretskii
2017-08-06 20:25 ` Mark Oteiza [this message]
2017-08-12 9:47 ` Eli Zaretskii
2017-08-12 16:10 ` Mark Oteiza
2017-08-12 16:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170806202543.GA1853@holos.localdomain \
--to=mvoteiza@udel.edu \
--cc=27895-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).