From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tak Kunihiro Newsgroups: gmane.emacs.bugs Subject: bug#27569: delete-selection on yank via popup-menu Date: Tue, 18 Jul 2017 13:35:07 +0900 (JST) Message-ID: <20170718.133507.914125065653421617.tkk@misasa.okayama-u.ac.jp> References: <20170705.081128.918140452192114950.tkk@misasa.okayama-u.ac.jp> <20170711.165928.1681891806866192564.tkk@misasa.okayama-u.ac.jp> <8737a2fogu.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1500352622 31285 195.159.176.226 (18 Jul 2017 04:37:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2017 04:37:02 +0000 (UTC) Cc: 27569@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 18 06:36:54 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXKFg-0007bm-R7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jul 2017 06:36:52 +0200 Original-Received: from localhost ([::1]:53891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKFm-0008B3-6x for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jul 2017 00:36:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXKEw-0007mr-3j for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 00:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXKEs-0006Dk-5j for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 00:36:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXKEs-0006Df-2E for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 00:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dXKEr-0000ty-NP for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 00:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tak Kunihiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2017 04:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27569 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27569-submit@debbugs.gnu.org id=B27569.15003525243414 (code B ref 27569); Tue, 18 Jul 2017 04:36:01 +0000 Original-Received: (at 27569) by debbugs.gnu.org; 18 Jul 2017 04:35:24 +0000 Original-Received: from localhost ([127.0.0.1]:45172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXKEG-0000t0-8G for submit@debbugs.gnu.org; Tue, 18 Jul 2017 00:35:24 -0400 Original-Received: from mxl065v65.mxlogic.net ([208.81.65.65]:40832 helo=s14p02o142.mxlogic.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXKED-0000sq-E8 for 27569@debbugs.gnu.org; Tue, 18 Jul 2017 00:35:23 -0400 Original-Received: from unknown [42.127.236.175] (EHLO mlsec.cc.okayama-u.ac.jp) by s14p02o142.mxlogic.net(mxl_mta-8.5.0-1834) over TLS secured channel with ESMTP id 4009d695.0.210373.00-385.452221.s14p02o142.mxlogic.net (envelope-from ); Mon, 17 Jul 2017 22:35:17 -0600 (MDT) X-MXL-Hash: 596d900576c4d088-1bf47517cfc4fda07f07dd8fd21c18a3568ccde7 Original-Received: from alml002.ouadm.okayama-u.ac.jp (unknown [42.127.236.168]) by mlsec.cc.okayama-u.ac.jp with smtp id 0978_9a56_7aab7a80_d4d0_4952_b642_3a75adf25095; Tue, 18 Jul 2017 13:35:09 +0900 Original-Received: from localhost (p1570088-omed01.osaka.ocn.ne.jp [153.250.17.87]) by alml002.ouadm.okayama-u.ac.jp (Postfix) with ESMTPSA id AF49A4C0B5A; Tue, 18 Jul 2017 13:35:09 +0900 (JST) In-Reply-To: <8737a2fogu.fsf@users.sourceforge.net> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 11 X-NAI-Spam-Score: 0.6 X-NAI-Spam-Rules: 5 Rules triggered TS_MSG_REP_20=0.6, EDT_SA_AU_PASS=0, EDT_SA_DN_PASS=0, EDT_SA_TS_PASS=0, RV6073=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6073> : inlines <5978> : streams <1754669> : uri <2465041> X-AnalysisOut: [v=2.2 cv=ebZNR/MH c=1 sm=1 tr=0 a=8LLPK8U+aGQ6qN8QlyMYtQ==] X-AnalysisOut: [:117 a=8LLPK8U+aGQ6qN8QlyMYtQ==:17 a=kj9zAlcOel0A:10 a=G3g] X-AnalysisOut: [G6ho9WtcA:10 a=r0jJkBentSEmttLwZKEA:9 a=7Zwj6sZBwVKJAoWSPK] X-AnalysisOut: [xL6X1jA+E=:19 a=CjuIK1q_8ugA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2017071714); S=0.230(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [42.127.236.175] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134698 Archived-At: The patch works well in my computer. Is it time to push? > tags 27569 + patch > quit > > Tak Kunihiro writes: > >> Could you push to the master? > > Okay, I'll wait a couple more days and then push the following (I think > doing setq on this-command makes more sense than let-binding after all). > > * lisp/menu-bar.el (popup-menu): Run `pre-command-hook' with > `this-command' set to the selected command. > --- > lisp/menu-bar.el | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el > index 9c7bcffbaa..107043b501 100644 > --- a/lisp/menu-bar.el > +++ b/lisp/menu-bar.el > @@ -2360,6 +2360,10 @@ (defun popup-menu (menu &optional position prefix from-menu-bar) > ;; `setup-specified-language-environment', for instance, > ;; expects this to be set from a menu keymap. > (setq last-command-event (car (last event))) > + ;; Update `this-command' and run `pre-command-hook' so that > + ;; things like `delete-selection-pre-hook' will work correctly. > + (setq this-command cmd) > + (run-hook 'pre-command-hook) > ;; mouse-major-mode-menu was using `command-execute' instead. > (call-interactively cmd)))) > > -- > 2.11.1