From: Alan Mackenzie <acm@muc.de>
To: Vasilij Schneidermann <mail@vasilij.de>
Cc: 26658-done@debbugs.gnu.org
Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map
Date: Wed, 12 Jul 2017 17:50:03 +0000 [thread overview]
Message-ID: <20170712175003.GA13295@acm> (raw)
In-Reply-To: <20170507135834.GB645@odonien.localdomain>
Hello, Vasilij.
On Sun, May 07, 2017 at 15:58:34 +0200, Vasilij Schneidermann wrote:
[ .... ]
> > Do you have commit access to the Emacs repository?
> No and I doubt I'll ever get it because I don't understand the commit
> message rules at all. They appear to be loosely based upon GNU
> changelog guidelines, but with everyone I send patches to interpreting
> them differently, probably because there isn't much substance to them in
> the first place. I've resorted to using M-x add-change-log-entry,
> copying the result into the commit message and adjusting it describing
> my changes, but there's apparently more to it than that.
I've committed your patch, slightly altered, and am closing the bug. I
suspect that the commit message I used will be yet another variant. ;-(
Thanks again for that patch.
> Anyway, here's an updated patch.
> >>From 1e4a92e05b78edb2f58c138aa7792d39a6d9a9cb Mon Sep 17 00:00:00 2001
> From: Vasilij Schneidermann <vasilij.schneidermann@bevuta.com>
> Date: Sun, 7 May 2017 15:55:49 +0200
> Subject: [PATCH] Make prog-mode-map the parent of c-mode-base-map
> Fixes #26658.
> * lisp/progmodes/cc-mode.el (c-mode-base-map): Make prog-mode-map the
> parent of c-mode-map if possible.
> ---
> lisp/progmodes/cc-mode.el | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el
> index 20c63d4dbe..8f9e40bb0d 100644
> --- a/lisp/progmodes/cc-mode.el
> +++ b/lisp/progmodes/cc-mode.el
> @@ -276,6 +276,9 @@ c-bind-special-erase-keys
> nil
> (setq c-mode-base-map (make-sparse-keymap))
> + (when (and (cc-bytecomp-fboundp 'set-keymap-parent)
> + (boundp 'prog-mode-map))
> + (set-keymap-parent c-mode-base-map prog-mode-map))
> ;; Separate M-BS from C-M-h. The former should remain
> ;; backward-kill-word.
> --
> 2.12.2
--
Alan Mackenzie (Nuremberg, Germany).
prev parent reply other threads:[~2017-07-12 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 18:52 bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Vasilij Schneidermann
2017-04-25 18:57 ` Glenn Morris
2017-04-26 6:30 ` bug#26658: " Jostein Kjønigsen
2017-04-26 6:37 ` Vasilij Schneidermann
2017-04-27 19:36 ` bug#26658: 25.2; " Alan Mackenzie
2017-04-28 8:15 ` Vasilij Schneidermann
2017-05-02 21:17 ` Vasilij Schneidermann
2017-05-07 11:22 ` Alan Mackenzie
2017-05-07 13:58 ` Vasilij Schneidermann
2017-07-12 17:50 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712175003.GA13295@acm \
--to=acm@muc.de \
--cc=26658-done@debbugs.gnu.org \
--cc=mail@vasilij.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).