bug#27617: 26.0.50; cl--random-state initialized to old-style vector

bug#27617: 26.0.50; cl--random-state initialized to old-style vector

[Christopher Wellons]

The global variable cl--random-state is still being initialized to the 
old defstruct vector format. See lisp/emacs-lisp/cl-lib.el:296. This 
breaks all random number functions when the STATE argument isn't 
supplied:

    $ emacs -Q --batch -l cl-lib --eval '(cl-random 10)'
    Wrong type argument: cl--random-state, [cl--random-state-tag -1 30 ...]

bug#27617: [PATCH] Fix cl--random-state initialization.

[Christopher Wellons]

Here's a trivial patch that fixes this bug.

---
  lisp/emacs-lisp/cl-lib.el | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el
index 936c852526c..ea47a0562ee 100644
--- a/lisp/emacs-lisp/cl-lib.el
+++ b/lisp/emacs-lisp/cl-lib.el
@@ -294,7 +294,7 @@ cl--random-time
      v))
  
  (defvar cl--random-state
-  (vector 'cl--random-state-tag -1 30 (cl--random-time)))
+  (record 'cl--random-state -1 30 (cl--random-time)))
  
  (defconst cl-most-positive-float nil
    "The largest value that a Lisp float can hold.
-- 
2.11.0

bug#27617: 26.0.50; cl--random-state initialized to old-style vector

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]

Thanks for reporting that. I installed the attached, which differs from what you 
suggested but should also work.

[-- Attachment #2: 0001-Remove-duplicate-cl-random-state-definition.patch --]
[-- Type: text/x-patch, Size: 928 bytes --]

From 6443a95ad74d54b8be5ba85af9b893f3f1d5fa02 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 14 Jul 2017 02:47:30 -0700
Subject: [PATCH] Remove duplicate cl--random-state definition

* lisp/emacs-lisp/cl-lib.el (cl--random-state): Remove.
This variable is now defined in cl-extra.el (Bug#27617).
---
 lisp/emacs-lisp/cl-lib.el | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el
index 936c852..3c9c622 100644
--- a/lisp/emacs-lisp/cl-lib.el
+++ b/lisp/emacs-lisp/cl-lib.el
@@ -293,9 +293,6 @@ cl--random-time
     (while (>= (cl-decf i) 0) (setq v (+ (* v 3) (aref time i))))
     v))
 
-(defvar cl--random-state
-  (vector 'cl--random-state-tag -1 30 (cl--random-time)))
-
 (defconst cl-most-positive-float nil
   "The largest value that a Lisp float can hold.
 If your system supports infinities, this is the largest finite value.
-- 
2.7.4