unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vasilij Schneidermann <v.schneidermann@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 27122@debbugs.gnu.org
Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex
Date: Mon, 29 May 2017 22:20:21 +0200	[thread overview]
Message-ID: <20170529202021.ax4reeivfvlijkqv@odonien.localdomain> (raw)
In-Reply-To: <834lw3fnju.fsf@gnu.org>

> Complexity and maintainability.  The code which handles special
> characters is already almost 140 lines of terse C, controlled by 2
> obscure variables (ever heard of printable-chars, for example?) and 2
> special faces.  And that's excluding the glyphless-char-display stuff,
> which adds even more.  It's almost impossible to tell in advance how
> will some specific codepoint be displayed if the terminal cannot
> handle it "normally".  At least I need to read the involved code every
> time I have to answer such questions.

While this is unfortunate, I find it more instructive to look at it in
terms of how much complexity is added (an extra conditional and a
customizable), not how much lurks in the existing code.  If you
constantly went by that argument, you would have to refrain from any
kind of Emacs hacking given its impenetrable code base.

The easiest way to solve this without adding any extra complexity would
be simply replacing the format string by the hex one.  I wouldn't want
to be involved in the ensuing discussion though...





  reply	other threads:[~2017-05-29 20:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 20:42 bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex Vasilij Schneidermann
2017-05-29  2:33 ` Eli Zaretskii
2017-05-29  6:28   ` Vasilij Schneidermann
2017-05-29 18:46     ` Robert Cochran
2017-05-29 19:52       ` Eli Zaretskii
2017-05-29 20:20         ` Vasilij Schneidermann [this message]
2017-05-29 23:55           ` Robert Cochran
2017-05-30  0:11             ` npostavs
2017-05-30  0:47               ` Robert Cochran
2017-05-29 19:39     ` Eli Zaretskii
2017-05-29 20:15       ` Vasilij Schneidermann
2017-05-30  6:24         ` Eli Zaretskii
2017-05-30  8:16           ` Vasilij Schneidermann
2017-05-30  8:38             ` Eli Zaretskii
2017-06-01 17:05               ` Vasilij Schneidermann
2017-06-01 18:19                 ` Eli Zaretskii
2017-05-30 12:06           ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529202021.ax4reeivfvlijkqv@odonien.localdomain \
    --to=v.schneidermann@gmail.com \
    --cc=27122@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).