unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vasilij Schneidermann <mail@vasilij.de>
To: Alan Mackenzie <acm@muc.de>
Cc: 26658@debbugs.gnu.org
Subject: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map
Date: Fri, 28 Apr 2017 10:15:22 +0200	[thread overview]
Message-ID: <20170428081522.GA649@odonien.localdomain> (raw)
In-Reply-To: <20170427193636.GA2683@acm>

> So yes, this change would surely be a good idea, given that this CC Mode
> is derived from prog-mode anyway.

The more I think about it, the less sure I become.  Pretty much every
CC-derived mode does (define-derived-mode my-mode prog-mode ...) anyway
and according to the macro expansion, its keymap's parent is set to
(current-local-map) which should be equivalent to `prog-mode-map'.
Could very well be a non-issue in practice and merely faulty testing by
the user...

> Do you want to write the patch?  If so, have you got copyright
> assignments, or can you manage to write it as an "insignificant" (i.e.
> very small) change?  I think the limit for insignificant changes is less
> than 15 lines, but I'm not absolutely sure.  This wouldn't even need any
> changes in the manual.  :-)
> 
> If you don't really want to write the patch, just say so, and I'll do
> it.

I've assigned copyright already, but reckon this is a one-line patch.
Before I submit anything, I'd like to make sure it's needed and the
change works out as expected.





  reply	other threads:[~2017-04-28  8:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 18:52 bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map Vasilij Schneidermann
2017-04-25 18:57 ` Glenn Morris
2017-04-26  6:30 ` bug#26658: " Jostein Kjønigsen
2017-04-26  6:37   ` Vasilij Schneidermann
2017-04-27 19:36 ` bug#26658: 25.2; " Alan Mackenzie
2017-04-28  8:15   ` Vasilij Schneidermann [this message]
2017-05-02 21:17   ` Vasilij Schneidermann
2017-05-07 11:22     ` Alan Mackenzie
2017-05-07 13:58       ` Vasilij Schneidermann
2017-07-12 17:50         ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428081522.GA649@odonien.localdomain \
    --to=mail@vasilij.de \
    --cc=26658@debbugs.gnu.org \
    --cc=acm@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).