From: Alan Third <alan@idiocy.org>
To: Henrik Nyman <henrikjohannesnyman@gmail.com>
Cc: 22060@debbugs.gnu.org
Subject: bug#22060: 25.1.50; Fringe faces or not honored in 25.1.50.1 on OSX 10.11 installed via homebrew --use-git-head --cocoa
Date: Mon, 24 Apr 2017 10:48:08 +0100 [thread overview]
Message-ID: <20170424094808.GA99570@breton.holly.idiocy.org> (raw)
In-Reply-To: <CADHidMq6YQVB+0FUpwd_QYQjEim_9pbUv=8Ff3J-=hQsSiMPZA@mail.gmail.com>
On Sun, Apr 23, 2017 at 07:40:17PM +0000, Henrik Nyman wrote:
> Referred to this issue at:
>
> https://github.com/flycheck/flycheck/issues/811#issuecomment-296476404
>
>
> I hope this helps with creating a proper fix.
I’ve pushed a fix to the master branch. Can you please give it a try?
> (there probably was a reason to save the foreground color in a
> member variable in the first place).
I think the old code just looked at the alpha channel to determine
whether any particular pixel was background or foreground, but the new
code uses the actual colour value.
If you then change the foreground colour, you have to look for that
new colour the next time you want to change it.
I’m not really sure why that specific change was made. I can only
assume that the alpha channel isn’t always a perfect guide.
--
Alan Third
next prev parent reply other threads:[~2017-04-24 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 12:35 bug#22060: 25.1.50; Fringe faces or not honored in 25.1.50.1 on OSX 10.11 installed via homebrew --use-git-head --cocoa Julien Wintz
2015-12-04 6:46 ` Alex Dunn
2016-12-08 22:07 ` Glenn Morris
2017-04-23 19:40 ` Henrik Nyman
2017-04-24 9:48 ` Alan Third [this message]
2017-04-24 10:30 ` Henrik Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424094808.GA99570@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=22060@debbugs.gnu.org \
--cc=henrikjohannesnyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).