unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Werner LEMBERG <wl@gnu.org>
To: eliz@gnu.org
Cc: 25945@debbugs.gnu.org
Subject: bug#25945: Emacs aborts while calling FT_Load_Glyph
Date: Fri, 03 Mar 2017 09:32:17 +0100 (CET)	[thread overview]
Message-ID: <20170303.093217.2084474536954401081.wl@gnu.org> (raw)
In-Reply-To: <83bmtin5o5.fsf@gnu.org>


>> New code for (a) is quite simple:
>> 
>>   if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_DEFAULT) != 0)
>>     if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_NO_HINTING) != 0)
>>       ...
> 
> This should probably be accompanied by a suitable FONT_ADD_LOG call,
> to mention that this fallback was taken.

Yes, perhaps.  However, if all glyphs are broken you will get a huuge
logfile...

>> My knowledge of Emacs internals is too small to provide an
>> implementation for (b).
> 
> I think it's too late for (b) when we discover this problem in
> ftfont_get_metrics.  To do (b) we should have discovered this in
> ftfont_has_char, or thereabouts.

Interesting.  How comes that Emacs aborts right there?

A note regarding the Padauk font: The problem is partly due to
FreeType 2.7.1, which has a stricter looping limit for TrueType
bytecode to detect endless loops – for this font, however, the limit
is a bit too strict; I will fix this in the next FreeType release.
Regardless of that, the bytecode in Padauk *is* buggy, and I've
already contacted the maintainers, asking for a new release using a
new, fixed ttfautohint version.

  https://github.com/silnrsi/font-padauk/issues/12


     Werner

  reply	other threads:[~2017-03-03  8:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  7:04 bug#25945: Emacs aborts while calling FT_Load_Glyph Werner LEMBERG
2017-03-03  8:08 ` Eli Zaretskii
2017-03-03  8:32   ` Werner LEMBERG [this message]
2017-03-03  8:43     ` Eli Zaretskii
2017-03-03 10:37       ` Werner LEMBERG
2017-03-03 13:43         ` Eli Zaretskii
2017-03-04  5:39           ` Werner LEMBERG
2017-03-04  9:32             ` Eli Zaretskii
2017-03-11 19:08   ` Eli Zaretskii
2017-04-11 10:08 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170303.093217.2084474536954401081.wl@gnu.org \
    --to=wl@gnu.org \
    --cc=25945@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).