bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[frederik]

(I'm sending this via my MUA because 'M-x mail-send' didn't work)

In my ~/.emacs file, I get repeating lines like this:

;; Added by Package.el.  This must come before configurations of
;; installed packages.  Don't delete this line.  If you don't want it,
;; just comment it out by adding a semicolon to the start of the line.
;; You may delete these explanatory comments.

;; Added by Package.el.  This must come before configurations of
;; installed packages.  Don't delete this line.  If you don't want it,
;; just comment it out by adding a semicolon to the start of the line.
;; You may delete these explanatory comments.

;; Added by Package.el.  This must come before configurations of
;; installed packages.  Don't delete this line.  If you don't want it,
;; just comment it out by adding a semicolon to the start of the line.
;; You may delete these explanatory comments.

;; Added by Package.el.  This must come before configurations of
;; installed packages.  Don't delete this line.  If you don't want it,
;; just comment it out by adding a semicolon to the start of the line.
;; You may delete these explanatory comments.
(package-initialize)

(package-initialize)

(package-initialize)

(package-initialize)

I'm not sure when they appear but I upgraded recently and cleared them
out, and they keep appearing.



In GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.5)
 of 2016-12-23 built on juergen
Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe
 -fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: 
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  global-auto-revert-mode: t
  shell-dirtrack-mode: t
  savehist-mode: t
  override-global-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: on
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  hs-minor-mode: t

Recent messages:
When done with a buffer, type C-x #
Unable to load color "brightblue"
Unable to load color "brightred"
scroll-up-command: End of buffer [9 times]
Mark set [2 times]
Making completion list... [2 times]
Quit
Making completion list...
Quit
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message idna dired rfc822 mml mml-sec
epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils
ispell skeleton pulse misearch multi-isearch imenu conf-mode cus-edit
cus-start cus-load term/xterm xterm ggtags etags xref project ewoc
cc-mode derived cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align
cc-engine cc-langs cc-bytecomp jka-compr rx edmacro kmacro autorevert
filenotify ido ess-toolbar ess-mouse mouseme thingatpt+ thingatpt
browse-url ess-menu ess-swv ess-noweb ess-noweb-font-lock-mode
ess-bugs-l essd-els ess-sas-d ess-sas-l ess-sas-a ess-sta-d ess-sta-l
cc-vars cc-defs make-regexp ess-sp6-d ess-dde ess-sp3-d ess-julia
julia-mode ess-r-d ess-r-syntax ess-r-completion ess-roxy essddr
noutline outline hideshow ess-help ess-r-package ess-s-l ess ess-inf
ess-tracebug tramp tramp-compat auth-source cl-seq gnus-util mm-util
mail-prsvr password-cache tramp-loaddefs trampver ucs-normalize shell
pcomplete format-spec advice ess-mode ess-noweb-mode ess-utils time-date
ess-generics ess-custom executable ess-compat ess-site savehist iflipb
bind-key compile easy-mmode comint ansi-color ring cl help-fns+ wid-edit
help-fns server finder-inf eieio eieio-core cl-macs info package
epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode
easymenu cconv cl-loaddefs pcase cl-lib mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
dbusbind inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 367952 28799)
 (symbols 48 33895 2)
 (miscs 40 300 1363)
 (strings 32 61653 13739)
 (string-bytes 1 1782835)
 (vectors 16 53797)
 (vector-slots 8 1576608 178209)
 (floats 8 373 636)
 (intervals 56 6020 793)
 (buffers 976 46))

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[Glenn Morris]

frederik@ofb.net wrote:

> In my ~/.emacs file, I get repeating lines like this:
[...]
> (package-initialize)
>
> (package-initialize)
>
> (package-initialize)

The function package--ensure-init-file adds this line, but it takes care
to only do so if it's not already there. So it's hard to see how you can
end up with multiple copies. Can you find a reproducible sequence that
causes an extra copy to be added; or can you edebug
package--ensure-init-file to see why it adds multiple copies?

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[frederik]

On Tue, Feb 21, 2017 at 05:19:14PM -0500, Glenn Morris wrote:
> frederik@ofb.net wrote:
> 
> > In my ~/.emacs file, I get repeating lines like this:
> [...]
> > (package-initialize)
> >
> > (package-initialize)
> >
> > (package-initialize)
> 
> The function package--ensure-init-file adds this line, but it takes care
> to only do so if it's not already there. So it's hard to see how you can
> end up with multiple copies. Can you find a reproducible sequence that
> causes an extra copy to be added; or can you edebug
> package--ensure-init-file to see why it adds multiple copies?
> 

Thanks for the reply. Well, you prompted me to find a reproducible
sequence. It turns out that the problem comes from when I start emacs
as "root". (This happens automatically in ~/.xinitrc, for better or
worse, where I create a screen session with an emacs running as root,
which starts a server so that I can edit files using emacsclient as
root) My /root/.emacs looks something like this:

    (setenv "HOME" "/home/frederik/")
    (setq savehist-file "/root/.emacs-history")
    (load "~/.emacs")
    (setenv "HOME" "/root/")

Obviously this does not contain a "(package-initialize)" line, so the
following test in package--ensure-init-file fails:

              ;; Don't visit the file if we don't have to.
              (with-temp-buffer
                (insert-file-contents user-init-file)
                (goto-char (point-min))
                (re-search-forward "(package-initialize\\_>" nil 'noerror))

(by the way what's with the unnecessary optimization in the lines
previous to these? ugh)

I wasn't able to figure out why the "(package-initialize)" lines then
get inserted in ~/.emacs rather than /root/.emacs, but I hope the
above clues provide a good enough place for someone else to start
debugging this.

Thank you!

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[Glenn Morris]

frederik@ofb.net wrote:

> root) My /root/.emacs looks something like this:
>
>     (setenv "HOME" "/home/frederik/")
>     (setq savehist-file "/root/.emacs-history")
>     (load "~/.emacs")
>     (setenv "HOME" "/root/")
>
> Obviously this does not contain a "(package-initialize)" line, so the
[...]
> I wasn't able to figure out why the "(package-initialize)" lines then
> get inserted in ~/.emacs rather than /root/.emacs, but I hope the
> above clues provide a good enough place for someone else to start
> debugging this.

I tested with:

/tmp/h1/.emacs:
    (setenv "HOME" "/tmp/h2/")
    (setq savehist-file "/tmp/h1/.emacs-history")
    (load "~/.emacs")
    (setenv "HOME" "/tmp/h1/")

/tmp/h2/.emacs:
    (setq foo 99)


HOME=/tmp/h1 emacs-25.1
M-x package-initialize

and could not reproduce any problem.
The package lines get added to /tmp/h1/.emacs, once only.

If you don't feel like debugging further, you could just add a
commented out package-initialize line to /root/.emacs.
Somehow I don't think your problem is a common one. :)

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[frederik]

On Wed, Feb 22, 2017 at 02:28:27PM -0500, Glenn Morris wrote:
> frederik@ofb.net wrote:
> 
> > root) My /root/.emacs looks something like this:
> >
> >     (setenv "HOME" "/home/frederik/")
> >     (setq savehist-file "/root/.emacs-history")
> >     (load "~/.emacs")
> >     (setenv "HOME" "/root/")
> >
> > Obviously this does not contain a "(package-initialize)" line, so the
> [...]
> > I wasn't able to figure out why the "(package-initialize)" lines then
> > get inserted in ~/.emacs rather than /root/.emacs, but I hope the
> > above clues provide a good enough place for someone else to start
> > debugging this.
> 
> I tested with:
> 
> /tmp/h1/.emacs:
>     (setenv "HOME" "/tmp/h2/")
>     (setq savehist-file "/tmp/h1/.emacs-history")
>     (load "~/.emacs")
>     (setenv "HOME" "/tmp/h1/")
> 
> /tmp/h2/.emacs:
>     (setq foo 99)
> 
> 
> HOME=/tmp/h1 emacs-25.1
> M-x package-initialize
> 
> and could not reproduce any problem.
> The package lines get added to /tmp/h1/.emacs, once only.
> 
> If you don't feel like debugging further, you could just add a
> commented out package-initialize line to /root/.emacs.
> Somehow I don't think your problem is a common one. :)

You don't think my problem is common!? :) Well I'm not sure how other
people edit files as root, but after a few incarnations I decided that
a barebones /root/.emacs pointing to ~/.emacs is the best way to go.

Thank you (indeed) for taking the time to trim down my problem to a
minimal test case. If we make it a little less minimal:

/tmp/h2/.emacs:
    (setq foo 99)
    (package-initialize)

then I find it reproduces the problem:

/tmp/h2/.emacs:
    ;; Added by Package.el.  This must come before configurations of
    ;; installed packages.  Don't delete this line.  If you don't want it,
    ;; just comment it out by adding a semicolon to the start of the line.
    ;; You may delete these explanatory comments.
    (package-initialize)

    (setq foo 99)
    (package-initialize)

Thanks,

Frederick

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[npostavs]

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

forcemerge 25819 24643
tags 25819 patch
quit

frederik@ofb.net writes:

> On Wed, Feb 22, 2017 at 02:28:27PM -0500, Glenn Morris wrote:
>> 
>> I tested with:
>> 
>> /tmp/h1/.emacs:
>>     (setenv "HOME" "/tmp/h2/")
>>     (setq savehist-file "/tmp/h1/.emacs-history")
>>     (load "~/.emacs")
>>     (setenv "HOME" "/tmp/h1/")
>> 
>> /tmp/h2/.emacs:
>>     (setq foo 99)
>> 
>> 
>> HOME=/tmp/h1 emacs-25.1
>> M-x package-initialize
>
> You don't think my problem is common!? :) Well I'm not sure how other
> people edit files as root,

Probably with TRAMP: https://www.emacswiki.org/emacs/TrampMode#toc20

> Thank you (indeed) for taking the time to trim down my problem to a
> minimal test case. If we make it a little less minimal:
>
> /tmp/h2/.emacs:
>     (setq foo 99)
>     (package-initialize)
>
> then I find it reproduces the problem:

AFAICT, this is essentially the problem described in #24643 and should be
fixed by the suggestion there:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1767 bytes --]

From aeae23ab082e948eca71ead3ea50a49a4fe73251 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Wed, 22 Feb 2017 21:12:41 -0500
Subject: [PATCH v1] Don't call package--ensure-init-file if initialized during
 startup

* lisp/emacs-lisp/package.el (package-initialize): Check
`after-init-time' rather than `load-file-name' to decide if
`package--ensure-init-file' should be called.  Depending on
`load-file-name' will fail if the user calls `pacakge-initialize' in
file which is loaded from the init file (Bug#24643, Bug#25819).
---
 lisp/emacs-lisp/package.el | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 0851c5e1fd..ee4bb750ab 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1445,13 +1445,13 @@ package-initialize
 taken care of by `package-initialize'."
   (interactive)
   (setq package-alist nil)
-  (if (equal user-init-file load-file-name)
-      ;; If `package-initialize' is being called as part of loading
-      ;; the init file, it's obvious we don't need to ensure-init.
-      (setq package--init-file-ensured t
-            ;; And likely we don't need to run it again after init.
-            package-enable-at-startup nil)
-    (package--ensure-init-file))
+  (if after-init-time
+      (package--ensure-init-file)
+    ;; If `package-initialize' is before we finished loading the init
+    ;; file, it's obvious we don't need to ensure-init.
+    (setq package--init-file-ensured t
+          ;; And likely we don't need to run it again after init.
+          package-enable-at-startup nil))
   (package-load-all-descriptors)
   (package-read-all-archive-contents)
   (unless no-activate
-- 
2.11.1

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[Glenn Morris]

frederik@ofb.net wrote:

>> > root) My /root/.emacs looks something like this:
>> >
>> >     (setenv "HOME" "/home/frederik/")
>> >     (setq savehist-file "/root/.emacs-history")
>> >     (load "~/.emacs")
>> >     (setenv "HOME" "/root/")
>> If you don't feel like debugging further, you could just add a
>> commented out package-initialize line to /root/.emacs.
>> Somehow I don't think your problem is a common one. :)
>
> You don't think my problem is common!? :) Well I'm not sure how other
> people edit files as root, but after a few incarnations I decided that
> a barebones /root/.emacs pointing to ~/.emacs is the best way to go.

I meant the odd use of changing HOME to load someone else's .emacs.
As it turns out, that isn't related.

(Did you consider symlinking ~frederik.emacs to /root/.emacs, and adding
UID == 0 conditionals where needed?)

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[frederik]

Thank you!

On Wed, Feb 22, 2017 at 09:28:02PM -0500, npostavs@users.sourceforge.net wrote:
> forcemerge 25819 24643
> tags 25819 patch
> quit
> 
> frederik@ofb.net writes:
> 
> > On Wed, Feb 22, 2017 at 02:28:27PM -0500, Glenn Morris wrote:
> >> 
> >> I tested with:
> >> 
> >> /tmp/h1/.emacs:
> >>     (setenv "HOME" "/tmp/h2/")
> >>     (setq savehist-file "/tmp/h1/.emacs-history")
> >>     (load "~/.emacs")
> >>     (setenv "HOME" "/tmp/h1/")
> >> 
> >> /tmp/h2/.emacs:
> >>     (setq foo 99)
> >> 
> >> 
> >> HOME=/tmp/h1 emacs-25.1
> >> M-x package-initialize
> >
> > You don't think my problem is common!? :) Well I'm not sure how other
> > people edit files as root,
> 
> Probably with TRAMP: https://www.emacswiki.org/emacs/TrampMode#toc20
> 
> > Thank you (indeed) for taking the time to trim down my problem to a
> > minimal test case. If we make it a little less minimal:
> >
> > /tmp/h2/.emacs:
> >     (setq foo 99)
> >     (package-initialize)
> >
> > then I find it reproduces the problem:
> 
> AFAICT, this is essentially the problem described in #24643 and should be
> fixed by the suggestion there:
> 

> From aeae23ab082e948eca71ead3ea50a49a4fe73251 Mon Sep 17 00:00:00 2001
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 22 Feb 2017 21:12:41 -0500
> Subject: [PATCH v1] Don't call package--ensure-init-file if initialized during
>  startup
> 
> * lisp/emacs-lisp/package.el (package-initialize): Check
> `after-init-time' rather than `load-file-name' to decide if
> `package--ensure-init-file' should be called.  Depending on
> `load-file-name' will fail if the user calls `pacakge-initialize' in
> file which is loaded from the init file (Bug#24643, Bug#25819).
> ---
>  lisp/emacs-lisp/package.el | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index 0851c5e1fd..ee4bb750ab 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1445,13 +1445,13 @@ package-initialize
>  taken care of by `package-initialize'."
>    (interactive)
>    (setq package-alist nil)
> -  (if (equal user-init-file load-file-name)
> -      ;; If `package-initialize' is being called as part of loading
> -      ;; the init file, it's obvious we don't need to ensure-init.
> -      (setq package--init-file-ensured t
> -            ;; And likely we don't need to run it again after init.
> -            package-enable-at-startup nil)
> -    (package--ensure-init-file))
> +  (if after-init-time
> +      (package--ensure-init-file)
> +    ;; If `package-initialize' is before we finished loading the init
> +    ;; file, it's obvious we don't need to ensure-init.
> +    (setq package--init-file-ensured t
> +          ;; And likely we don't need to run it again after init.
> +          package-enable-at-startup nil))
>    (package-load-all-descriptors)
>    (package-read-all-archive-contents)
>    (unless no-activate
> -- 
> 2.11.1
> 

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[frederik]

> > You don't think my problem is common!? :) Well I'm not sure how other
> > people edit files as root, but after a few incarnations I decided that
> > a barebones /root/.emacs pointing to ~/.emacs is the best way to go.
> 
> I meant the odd use of changing HOME to load someone else's .emacs.
> As it turns out, that isn't related.
> 
> (Did you consider symlinking ~frederik.emacs to /root/.emacs, and adding
> UID == 0 conditionals where needed?)

Yes I think this was one thing I tried. I can't remember what went
wrong there, but one thing is I have a bunch of lines like this in my
~/.emacs:

    (load "~/.emacs.d/fhe-bury-buffer.el")

So I think $HOME has to be changed to ~/, while ~/.emacs is being
read, as you can see in my earlier message. But it turns out that this
was pretty much enough.

Tramp looks cool; I wish I'd known about it before, but now I use
sshfs and sudo and this obviates most of the uses for me.

I don't use the Emacs GUI - strictly terminal here - and I often open
files from the command line, via emacsclient, rather than C-x C-f.
Particularly for stuff like configuration files that I end up editing
as root.

.zprofile: export EDITOR="emacsclient -c -nw"
.zshrc: alias em=$EDITOR

I don't know what you'd call my usage pattern but it's perhaps more
like a vim user, using the editor from the shell and keeping it
lightweight.

bug#25819: 25.1; Added by Package.el. Added by Package.el. Added by Package.el. Added by Package.el.

[npostavs]

tags 25819 fixed
close 25819 26.1
quit

frederik@ofb.net writes:

> Thank you!
>
>> 
>> AFAICT, this is essentially the problem described in #24643 and should be
>> fixed by the suggestion there:

Pushed to master [1: 6b6cc56e72].

1: 2017-02-26 11:11:40 -0500 6b6cc56e728a4d8b5ccac86ac393be7cd29207e2
  Don't call package--ensure-init-file if initialized during startup