From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Date: Wed, 8 Feb 2017 13:55:23 +0100 Message-ID: <20170208125523.GA703@odonien.localdomain> References: <8760kyzoma.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1486558580 11498 195.159.176.226 (8 Feb 2017 12:56:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2017 12:56:20 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 25561@debbugs.gnu.org, Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 08 13:56:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbRn6-0002QT-AO for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 13:56:08 +0100 Original-Received: from localhost ([::1]:59106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbRnC-0002lm-2w for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 07:56:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbRn6-0002lf-D1 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 07:56:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbRn0-0004eJ-8x for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 07:56:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbRn0-0004eF-55 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 07:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cbRmz-0000K6-UT for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 07:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2017 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25561 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25561-submit@debbugs.gnu.org id=B25561.14865585331206 (code B ref 25561); Wed, 08 Feb 2017 12:56:01 +0000 Original-Received: (at 25561) by debbugs.gnu.org; 8 Feb 2017 12:55:33 +0000 Original-Received: from localhost ([127.0.0.1]:59664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbRmX-0000JO-Fx for submit@debbugs.gnu.org; Wed, 08 Feb 2017 07:55:33 -0500 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:34226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbRmU-0000J5-Ot for 25561@debbugs.gnu.org; Wed, 08 Feb 2017 07:55:31 -0500 Original-Received: by mail-wm0-f66.google.com with SMTP id c85so33092850wmi.1 for <25561@debbugs.gnu.org>; Wed, 08 Feb 2017 04:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1q84zkwRZJAWkSfpOda1l3tT4yu4j67mH/ycVXNn6FA=; b=MihseFwAkr3F36NDeW1dOfVdZIjbSIBYTHeQazxwSGqqMmOwjLb/241ssfS+RPmK+5 1oTOWkUOYjhQ1vTROktFmluQbDRF6nJ8X3/rZn6cRPAxblNY71BmWUlQfouJt0eouq9B bF/kApipQ25Gzqk67mAZ/WMqHG8JfmmyLcqK5uY1PdsnX7gvxSWIBychjf9pqCg9gd+m o0rv83wNS26xYCTuXzYqYGZtCvcU/5PkvnLAG1uFaT4XzI/kPN+SGnUcUwFwDQPV7lU8 xHuwtDbCFANZyWou48oAoec82fc3mUN3tUdROdvsCeN1ASSKvSEDmYu8SJI5HNnfiwdS aVug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1q84zkwRZJAWkSfpOda1l3tT4yu4j67mH/ycVXNn6FA=; b=PkB/PENIeOlbAi0juGTeVoyyiuUFt4Dmb66VV/JtzjkXq5aUb2Waoi4RWDQqylPL++ ZvIumzl62GVu29EP8Li5y/rd6jF31o7hyDnGSWCHWMNvHXhljcuwM/RPqeM5w18azRDq hnjModksiNPIKMjzj4wsKDgSiAmPUdlp03wfIvj0Rl9uXD+Hw5k8BTxFrAeH0nW03YnN 88zWZjCNQcbxrLTzc1EXzN41aVFN7wPMFQTuIGZg1GRnmb/jV1d8tT2OWBwY2YbwL3lP GZh2tXJnQX1Nwuk2SDvSjcwFD9bA+ryo+ruXgfhIg/hl7O1qXTpfNlSw2mDZhteHrHxP v4Pg== X-Gm-Message-State: AMke39nLo6R4UWcy1O7Vl0PBZljQ/X7V4oncsCXvnCUUyUHXVhnjzjuOKDg/r7kmaOua9w== X-Received: by 10.28.189.195 with SMTP id n186mr16594229wmf.77.1486558524790; Wed, 08 Feb 2017 04:55:24 -0800 (PST) Original-Received: from localhost (dslb-088-078-199-035.088.078.pools.vodafone-ip.de. [88.78.199.35]) by smtp.gmail.com with ESMTPSA id i15sm3198173wmf.21.2017.02.08.04.55.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Feb 2017 04:55:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <8760kyzoma.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129119 Archived-At: Bumping this thread to CC Stefan Monnier as well. On 01/29/17 at 02:39am, Juri Linkov wrote: > > Hello, > > > > a user of the Evil package reported [1] that using a search command > > results in a "Making isearch-search-fun-function local to *Minibuf-1* > > while let-bound!" warning. This appears to be an interaction between > > isearch and Evil, more specifically, Evil let-binds > > `isearch-search-fun-function' to something of its own, invokes isearch > > and something in isearch ends up running > > `minibuffer-history-isearch-setup' which `make-local-variable' to have > > `isearch-search-fun-function' have a separate value, resulting in the > > aforementioned warning. > > > > What's the recommended way to avoid or silence it? Stefan suggested > > elsewhere [2] that this might indicate a bug, hence why I'm bringing > > this up here. > > > > [1]: https://github.com/emacs-evil/evil/issues/748 > > [2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html > > Thanks for the report. I'm not familiar with the Evil package, > so please correct me if I make wrong guesses about it. I suppose > that the basic mode of operation of the Evil package is not buffer-local. > In this case I believe (make-local-variable 'isearch-search-fun-function) > is the wrong fix because it will make this variable have this value > in every random buffer where the user happens to invoke the search command. > > OTOH, if evil-mode is the global mode then it makes sense to change the > global value of isearch-search-fun-function (and perhaps keeping its > old value). If you need to keep standard search commands working, > then you could create a new internal defvar e.g. evil-search-is-active, > set it temporarily in evil-search commands, and check it in your new > implementation of the search function in isearch-search-fun-function. > If evil-search-is-active is nil, then call the old default value > isearch-search-fun-default. > > I can't guarantee this solution to work, it's just an idea for you > to consider.