From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Date: Sun, 29 Jan 2017 13:25:24 +0100 Message-ID: <20170129122524.GA602@odonien.localdomain> References: <8760kyzoma.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1485692774 20555 195.159.176.226 (29 Jan 2017 12:26:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 12:26:14 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 25561@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 29 13:26:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXoYY-0004ch-Pa for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 13:26:07 +0100 Original-Received: from localhost ([::1]:55006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXoYe-0007y4-13 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 07:26:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXoYX-0007xm-TL for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 07:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXoYU-0003HE-PF for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 07:26:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51560) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXoYU-0003H8-LE for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 07:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXoYU-0005pS-Ff for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 07:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2017 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25561 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25561-submit@debbugs.gnu.org id=B25561.148569273322361 (code B ref 25561); Sun, 29 Jan 2017 12:26:02 +0000 Original-Received: (at 25561) by debbugs.gnu.org; 29 Jan 2017 12:25:33 +0000 Original-Received: from localhost ([127.0.0.1]:49759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXoY1-0005ob-5c for submit@debbugs.gnu.org; Sun, 29 Jan 2017 07:25:33 -0500 Original-Received: from mail-wm0-f67.google.com ([74.125.82.67]:34221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXoXz-0005oN-8w for 25561@debbugs.gnu.org; Sun, 29 Jan 2017 07:25:31 -0500 Original-Received: by mail-wm0-f67.google.com with SMTP id c85so70346082wmi.1 for <25561@debbugs.gnu.org>; Sun, 29 Jan 2017 04:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VEIhqdHgqKnf+omRZwku7uJFU4+qXT2A6gboPv57Wew=; b=lxz7lQRrKIUIWoRjrZWCZC7zPe09KERV9nclAUGT2otbWJgUW+LXaGAZaE0OVfU3K2 IQwujwSB24DuDdjou8aTlaeKo9QoG78jiJy2G6U7OPO8Ato0lbAXlp8qL2OEFJypjW8q sNvIJRTq4SDbmaURvzXTGaoKuI03DpOiGL1UoLReGbao0E9ZAiKbvys2/7xcO9cnpOSS rDo2eXjhqUiAXKR8x+whHT//53pdt6wWoz2OcoO4dov2lWxMCLvyyWNNywA/DGxE4WJj MPB2KbmY0Hg9xHA7xjEY59H81ZUMrqf8COEF9Y+vmM30pTJezd//JcctSvUZYgflQcJ7 iEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VEIhqdHgqKnf+omRZwku7uJFU4+qXT2A6gboPv57Wew=; b=mNHseq0q4QZu81daYzy9WAaaScH/BgbhPNB0jvSpEOAO6q8CnJaqwiZe/GjoMhIJpe /sIf1H6XBr2zhnAkfby+GmryhGQaAZsZqBgy3MGTR5F75tYPVNJyYxVXuVfCt8rV+N3u ttVqvcNsEn6tU3MJMYuYR1eJFoSGDp2o7gJPcxw4GFK1/AOhIPXm+HTqBgii/c3IakKy WAYev7ism0dfz0jCzKghFBuPFpUnQTu9sY27Xn5UWdnczOyfSyIGFpiYjejA7MdZQENJ qS5ybgb6/Nw2TLFSaGAey4jiaYTJlXs3FeUS9uD+Jazmo3yncBfdAbfEI4jquUH5q/Gi w9vw== X-Gm-Message-State: AIkVDXLG6H6xRBgeQfVBi62Oi8fs8SPujbCD+eZkiNJP4MVP36F+ASMcZ+MlaLynMyeJHA== X-Received: by 10.223.160.206 with SMTP id n14mr14597279wrn.31.1485692725476; Sun, 29 Jan 2017 04:25:25 -0800 (PST) Original-Received: from localhost (dslb-092-073-085-113.092.073.pools.vodafone-ip.de. [92.73.85.113]) by smtp.gmail.com with ESMTPSA id s17sm17515433wrc.6.2017.01.29.04.25.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jan 2017 04:25:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <8760kyzoma.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128752 Archived-At: > Thanks for the report. I'm not familiar with the Evil package, so > please correct me if I make wrong guesses about it. I suppose that > the basic mode of operation of the Evil package is not buffer-local. It's a bit trickier than that. Evil defines a minor mode (evil-local-mode), then a global minor mode (evil-mode) using it and a few more variables for state tracking. The supported mode of operation is therefore global, while still allowing to deactivate it on a per-buffer or even per-command basis (there's a command to deactivate Evil's keymaps for the duration of the next command). > OTOH, if evil-mode is the global mode then it makes sense to change > the global value of isearch-search-fun-function (and perhaps keeping > its old value). If you need to keep standard search commands working, > then you could create a new internal defvar e.g. > evil-search-is-active, set it temporarily in evil-search commands, and > check it in your new implementation of the search function in > isearch-search-fun-function. If evil-search-is-active is nil, then > call the old default value isearch-search-fun-default. Hm, this sounds hackier than the current approach, also, what if another package let-binds this variable for custom search functionality? The reason I reported this warning is because I suspect something about isearch and the minibuffer setup hook isn't done correctly, in hope of getting rid of the warning for every user of that variable.