From: Mark Oteiza <mvoteiza@udel.edu>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 25400@debbugs.gnu.org, npostavs@users.sourceforge.net,
Dima Kogan <dima@secretsauce.net>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
Dmitry Gutov <dgutov@yandex.ru>,
25105@debbugs.gnu.org
Subject: bug#25105: bug#25400: M-p in diff-mode jumps too far
Date: Wed, 11 Jan 2017 18:27:55 -0500 [thread overview]
Message-ID: <20170111232755.GA22069@holos.localdomain> (raw)
In-Reply-To: <87a8aydxe4.fsf@gmail.com>
On 11/01/17 at 01:38pm, Tino Calancha wrote:
> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
> > In a buffer with more than one hunk, if I'm in the middle of hunk number
> > N, diff-hunk-prev (usually bound to M-p) jumps to the header of hunk
> > number N-1 rather than to the header of hunk N.
> >
> > This is contrary to the usual behavior of Emacs's navigation commands.
> >As pointed out elsewhere, it's particularly obnoxious from EOB (in which
> >case, you're not really "within N" but you're virtually on "the header
> >of the non-existent hunk N+1", so going to the header of N-1 is really
> >wrong).
> >
> >I also dislike the fact that M-n doesn't let me get to EOB.
>
> Following patch reverts commit 2c8a7e5. Then it fixes dots 1. and 2.
> described in the commit message of 2c8a7e5, i.e., Bug#17544.
> This patch preserves the original definitions for 'diff-hunk-prev'
> and 'diff-hunk-next'.
>
> After applying locally this patch, you might want to do:
> git diff 2c8a7e5^ HEAD lisp/vc/diff-mode.el
> to see more clearly how it solves Bug#17544.
Works for me AFAICT. Thanks for working on it.
next prev parent reply other threads:[~2017-01-11 23:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 21:21 bug#25400: M-p in diff-mode jumps too far Stefan Monnier
2017-01-08 23:27 ` Mark Oteiza
2017-01-09 4:34 ` Stefan Monnier
2017-01-11 4:38 ` bug#25105: " Tino Calancha
2017-01-11 23:27 ` Mark Oteiza [this message]
2017-01-11 23:34 ` Dmitry Gutov
2017-01-12 3:53 ` bug#25400: " Tino Calancha
2017-01-13 3:35 ` Dmitry Gutov
2017-01-13 3:55 ` Tino Calancha
2017-01-14 3:11 ` bug#25105: bug#25400: " Dmitry Gutov
2017-01-21 3:02 ` Tino Calancha
2017-01-23 3:42 ` bug#25105: " Dmitry Gutov
2017-01-13 4:25 ` Tino Calancha
2017-01-13 5:57 ` bug#25105: " npostavs
2017-01-13 6:26 ` Tino Calancha
2017-01-13 6:42 ` bug#25105: " npostavs
2017-01-13 6:54 ` Tino Calancha
2017-01-14 1:49 ` npostavs
2017-01-14 5:47 ` Tino Calancha
2017-01-16 6:26 ` Tino Calancha
2017-01-17 23:24 ` Dmitry Gutov
2017-01-18 6:11 ` Tino Calancha
2017-01-14 3:16 ` bug#25105: bug#25400: " Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111232755.GA22069@holos.localdomain \
--to=mvoteiza@udel.edu \
--cc=25105@debbugs.gnu.org \
--cc=25400@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=dima@secretsauce.net \
--cc=monnier@IRO.UMontreal.CA \
--cc=npostavs@users.sourceforge.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).