From: Stephen Gildea <stepheng+emacs@gildea.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 51056@debbugs.gnu.org, mh-e-devel@lists.sourceforge.net
Subject: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete
Date: Wed, 06 Oct 2021 07:01:29 -0700 [thread overview]
Message-ID: <2016750.1633528889@tigger3.sg.gildea.net> (raw)
In-Reply-To: Message from larsi@gnus.org of 6 Oct 2021 12:14:13 +0200 <87wnmq5ukq.fsf@gnus.org>
+mh-e-devel
Lars Ingebrigtsen <larsi@gnus.org> wrote to me:
> Emacs 29 has grown a new function to define keymaps, `define-keymap'
> somewhat inspired by the more than two-decades-old macro
> `gnus-define-keys'.
>
> So I've now replaced all the usages of `gnus-define-keys' in Emacs 29
> with `define-keymap' and was about to make `gnus-define-keys' obsolete,
> but that macro is used by mh-e, too. mh-e is also distributed outside
> Emacs, if I understand correctly, so this code can't be converted.
>
> Stephen, would it make sense to copy the Gnus macro into mh-e, and
> rename it mh-define-keys? That way `gnus-define-keys' could be
> obsoleted.
>
> A different solution would be to write a new mh-define-keymap that more
> closely mimics the new `define-keymap' function, and then use it instead
> in mh-e -- that's probably a better long-term solution, because you
> could then remove the mh-define-keymap function at some later date (when
> you shift the mh-e target to Emacs 29+).
MH-E is no longer developed nor distributed separately from GNU Emacs,
since maybe 2015.
You can update the MH-E part of the Emacs source tree to use Emacs 29
features. No compatibility is needed.
Thanks for checking,
< Stephen
next prev parent reply other threads:[~2021-10-06 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 10:14 bug#51056: 29.0.50; Making `gnus-define-keys' obsolete Lars Ingebrigtsen
2021-10-06 14:01 ` Stephen Gildea [this message]
2021-10-06 21:09 ` Stefan Kangas
2021-10-07 2:48 ` Stephen Gildea
2021-10-11 19:00 ` Bill Wohler
[not found] ` <1178966.1633978812@olgas.newt.com>
2021-10-11 19:46 ` Stefan Kangas
2021-10-12 10:43 ` Lars Ingebrigtsen
[not found] ` <87o87ufrq8.fsf@gnus.org>
2021-10-12 11:44 ` Stefan Kangas
2021-10-07 7:46 ` bug#51070: " Lars Ingebrigtsen
2021-10-07 16:46 ` bug#51056: " Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2016750.1633528889@tigger3.sg.gildea.net \
--to=stepheng+emacs@gildea.com \
--cc=51056@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mh-e-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).