From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Olivier Certner Newsgroups: gmane.emacs.bugs Subject: bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes Date: Tue, 06 Jul 2021 18:34:48 +0200 Message-ID: <2016416.4WAli8B44Z__14575.4779850662$1625589318$gmane$org@ravel> References: <3089116.bT80LyP3VS@ravel> <877dj3xk3e.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27604"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-erc@gnu.org, 46775@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 06 18:35:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0o2R-0006z8-Kq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jul 2021 18:35:11 +0200 Original-Received: from localhost ([::1]:45474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0o2Q-00019H-NL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jul 2021 12:35:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0o2I-00015b-Nx for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 12:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0o2I-0006S8-Gc for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 12:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0o2I-0003ik-FY for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 12:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Olivier Certner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jul 2021 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46775 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46775-submit@debbugs.gnu.org id=B46775.162558929714287 (code B ref 46775); Tue, 06 Jul 2021 16:35:02 +0000 Original-Received: (at 46775) by debbugs.gnu.org; 6 Jul 2021 16:34:57 +0000 Original-Received: from localhost ([127.0.0.1]:49891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0o2C-0003iM-TJ for submit@debbugs.gnu.org; Tue, 06 Jul 2021 12:34:57 -0400 Original-Received: from smtp5-g21.free.fr ([212.27.42.5]:12674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0o2B-0003iE-9a for 46775@debbugs.gnu.org; Tue, 06 Jul 2021 12:34:56 -0400 Original-Received: from ravel.localnet (unknown [2.15.208.149]) (Authenticated sender: ocert.dev@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 9C1BE60174; Tue, 6 Jul 2021 18:34:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1625589293; bh=8BSACIhNp76w7DpsXJiBKzSJgmrboDadNVGPHb0MlNg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ab0tq8ftbpqu6S2796AuKZa5S9ze8MMVe6LZ1t9oxfoqKrl5dWf6WFayR9dfFwfNg mpWGdnzLLsZ8i5NRH/a3xw0NIhIbXhatrflCp5i1DuPnvirREehL8y/qe/GXK31+6F tWAuP9t9Q3Q04ZiULhzsZXwpDLwG4Fsnl3I4XyirRPiUD7WMmjKHiUgsshpOMwTJoj OLyCWYmZUUIAmfYiMOM0XjbLeWqjzRXBKsBo6j6ccdY46d2aYfkzQUSNyYG92DhfvW rvcEOBwq5tzrxkCfz5crs24ba0/lch9p/LQqF+Cl2ZswAmL1I5VNCRLeeLgdivnN5x 2T7Y0fs3DwtMg== In-Reply-To: <877dj3xk3e.fsf@neverwas.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209546 Archived-At: > The updates to the doc string here are likewise superb and make things > crystal clear. Thanks! > only 51% sure you meant s/necessary means/necessarily means/ in that I fixed the typo in the updated patch. > Regarding this module generally, it's definitely another one whose > layout confuses me. For example, I guess we can't add keymaps to minor > modes defined with `define-erc-module'? IOW, why the > `erc-track-minor-mode-map' instead of a `erc-track-mode-map'? The trick is that `erc-track-minor-mode' may be enabled or disabled independently of the whole module. In particular, it may not be activated at all if the (global) keybindings it wants to install, which don't abide by the rules for minor modes maps, are already bound at the time of module's activation. > I'm also confused by the 001 RPL_WELCOME hook, but for now, I'll just assume > it's a vestige of a simpler time when `erc-user-is-active' looked different > and maybe did more. Or (more likely) there's something I'm not seeing > just yet. `erc-user-is-active' seems in fact to be used for more than one purpose. In particular, it also triggers an update of channels in the mode line. What's exactly the problem with hooking on 001? > Anyway, I mention this stuff because you may be the best/only > qualified person to address such concerns at present. Would you be > willing to audit this file for redundancy/cruft/obsolescence at some > point before the next release? Thanks. Depending on available time and precise concerns that you may have, yes. There is a lot of room for improvement in this module. In particular in determining how some user is "active" (none of the current possibilities really suits my needs). -- Olivier Certner