* bug#25217: [PATCH] Enable sh-mode zshrc
@ 2016-12-17 9:06 Michihito Shigemura
2016-12-19 9:31 ` Alan Third
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Michihito Shigemura @ 2016-12-17 9:06 UTC (permalink / raw)
To: 25217; +Cc: Michihito Shigemura
* lisp/progmodes/sh-script.el (sh-mode):
Add zsh string-match
---
lisp/progmodes/sh-script.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5d362e4..ac5fb19 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1683,6 +1683,7 @@ sh-mode
((string-match "[.]bash\\>" buffer-file-name) "bash")
((string-match "[.]ksh\\>" buffer-file-name) "ksh")
((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
+ ((string-match "[.]zsh\\(rc\\)?\\>" buffer-file-name) "zsh")
((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
(t sh-shell-file))
nil nil)
--
2.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* bug#25217: [PATCH] Enable sh-mode zshrc
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
@ 2016-12-19 9:31 ` Alan Third
2016-12-19 13:15 ` bug#25217: (no subject) Michihito Shigemura
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Alan Third @ 2016-12-19 9:31 UTC (permalink / raw)
To: Michihito Shigemura; +Cc: 25217
Michihito Shigemura <m_shigemura@shigemk2.com> writes:
> * lisp/progmodes/sh-script.el (sh-mode):
> Add zsh string-match
> ---
> lisp/progmodes/sh-script.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
> index 5d362e4..ac5fb19 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -1683,6 +1683,7 @@ sh-mode
> ((string-match "[.]bash\\>" buffer-file-name) "bash")
> ((string-match "[.]ksh\\>" buffer-file-name) "ksh")
> ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
> + ((string-match "[.]zsh\\(rc\\)?\\>" buffer-file-name) "zsh")
> ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
> (t sh-shell-file))
> nil nil)
Hi, looks good.
Is it worth adding support for .zshenv as well?
--
Alan Third
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#25217: (no subject)
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
2016-12-19 9:31 ` Alan Third
@ 2016-12-19 13:15 ` Michihito Shigemura
2016-12-19 13:22 ` Alan Third
2016-12-20 12:12 ` bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Michihito Shigemura @ 2016-12-19 13:15 UTC (permalink / raw)
To: 25217
Thank you for your replying.
I can add support for .zshenv. But how can I send the improved patch?
Do I send it to 25217 at debbugs.gnu.org?
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#25217: [PATCH] Enable sh-mode zshrc
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
2016-12-19 9:31 ` Alan Third
2016-12-19 13:15 ` bug#25217: (no subject) Michihito Shigemura
@ 2016-12-20 12:12 ` Michihito Shigemura
2016-12-23 4:07 ` bug#25217: Michihito Shigemura
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Michihito Shigemura @ 2016-12-20 12:12 UTC (permalink / raw)
To: 25217; +Cc: Michihito Shigemura
* lisp/progmodes/sh-script.el (sh-mode):
Add zsh string-match
---
lisp/progmodes/sh-script.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5d362e4..a2c869d 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1683,6 +1683,7 @@ sh-mode
((string-match "[.]bash\\>" buffer-file-name) "bash")
((string-match "[.]ksh\\>" buffer-file-name) "ksh")
((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
+ ((string-match "[.]zsh\\(rc\\|env\\)?\\>" buffer-file-name) "zsh")
((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
(t sh-shell-file))
nil nil)
--
2.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* bug#25217:
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
` (2 preceding siblings ...)
2016-12-20 12:12 ` bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
@ 2016-12-23 4:07 ` Michihito Shigemura
2016-12-24 9:51 ` bug#25217: Alan Third
2016-12-24 14:11 ` bug#25217: Michihito Shigemura
2016-12-27 15:01 ` bug#25217: (no subject) Michihito Shigemura
5 siblings, 1 reply; 10+ messages in thread
From: Michihito Shigemura @ 2016-12-23 4:07 UTC (permalink / raw)
To: 25217
I sent new patch!
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#25217:
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
` (3 preceding siblings ...)
2016-12-23 4:07 ` bug#25217: Michihito Shigemura
@ 2016-12-24 14:11 ` Michihito Shigemura
2016-12-25 19:55 ` bug#25217: Alan Third
2016-12-27 15:01 ` bug#25217: (no subject) Michihito Shigemura
5 siblings, 1 reply; 10+ messages in thread
From: Michihito Shigemura @ 2016-12-24 14:11 UTC (permalink / raw)
To: 25217
Sorry, but I haven't contributed to Emacs before.
^ permalink raw reply [flat|nested] 10+ messages in thread* bug#25217:
2016-12-24 14:11 ` bug#25217: Michihito Shigemura
@ 2016-12-25 19:55 ` Alan Third
0 siblings, 0 replies; 10+ messages in thread
From: Alan Third @ 2016-12-25 19:55 UTC (permalink / raw)
To: Michihito Shigemura; +Cc: 25217-done
On Sat, Dec 24, 2016 at 11:11:10PM +0900, Michihito Shigemura wrote:
> Sorry, but I haven't contributed to Emacs before.
That’s good. If you had contributed before we might have had to get
you to assign copyright, but since it’s a small change we can let it
go. If you do decide to contribute again in the future you may have to
go through the process of assigning copyright.
I’ve pushed this change to the master branch.
Thank you!
--
Alan Third
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#25217: (no subject)
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
` (4 preceding siblings ...)
2016-12-24 14:11 ` bug#25217: Michihito Shigemura
@ 2016-12-27 15:01 ` Michihito Shigemura
5 siblings, 0 replies; 10+ messages in thread
From: Michihito Shigemura @ 2016-12-27 15:01 UTC (permalink / raw)
To: 25217
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
> That’s good. If you had contributed before we might have had to get
you to assign copyright, but since it’s a small change we can let it
go. If you do decide to contribute again in the future you may have to
go through the process of assigning copyright.
Thank you for your pushing my change. I'll be careful.
[-- Attachment #2: Type: text/html, Size: 1048 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-12-27 15:01 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-17 9:06 bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
2016-12-19 9:31 ` Alan Third
2016-12-19 13:15 ` bug#25217: (no subject) Michihito Shigemura
2016-12-19 13:22 ` Alan Third
2016-12-20 12:12 ` bug#25217: [PATCH] Enable sh-mode zshrc Michihito Shigemura
2016-12-23 4:07 ` bug#25217: Michihito Shigemura
2016-12-24 9:51 ` bug#25217: Alan Third
2016-12-24 14:11 ` bug#25217: Michihito Shigemura
2016-12-25 19:55 ` bug#25217: Alan Third
2016-12-27 15:01 ` bug#25217: (no subject) Michihito Shigemura
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).