unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25219-done@debbugs.gnu.org, rrt@sc3d.org
Subject: bug#25219: 26.0.50; ispell failing
Date: Sun, 18 Dec 2016 16:08:40 +0000	[thread overview]
Message-ID: <20161218160840.GA56991@breton.holly.idiocy.org> (raw)
In-Reply-To: <83vauh5kqw.fsf@gnu.org>

On Sun, Dec 18, 2016 at 05:18:15PM +0200, Eli Zaretskii wrote:
> > From: Alan Third <alan@idiocy.org>
> > Date: Sun, 18 Dec 2016 11:51:37 +0000
> > Cc: 25219@debbugs.gnu.org
> > 
> > > run M-x ispell-buffer
> > >
> > > watch it fail on fist word not in dictionry
> > >
> > > I use ispell before sending mail (dyslexia and sspect keyboad)
> > >
> > > een this way fo a week or so
> > 
> > It looks like this started with commit:
> > 
> > db6e1f82976a7f232a4a206a3c850ed34cfbfdd3
> > 
> > The following patch appears to fix the problem for me, but I have my
> > doubts it's the best way to handle it and I've only tested with
> > hunspell.
> > 
> > modified   lisp/textmodes/ispell.el
> > @@ -3338,7 +3338,7 @@ ispell-process-line
> >  	  ;; Markers can move with highlighting!  This destroys
> >  	  ;; end of region markers line-end and ispell-region-end
> >  	  (let ((word-start
> > -		 (copy-marker (+ ispell-start (car (cdr poss)))))
> > +		 (copy-marker (+ ispell-start -1 (car (cdr poss)))))
> >  		(word-len (length (car poss)))
> >  		(line-end (copy-marker ispell-end))
> >  		(line-start (copy-marker ispell-start))
> > 
> > Any thoughts?
> 
> We definitely need to keep the -1 offset there.  (It was previously
> supplied by ispell-offset, but that variable was deleted.)  The reason
> for the offset is that the line we send to the speller has a "^"
> prepended to it (see the documentation of the Ispell interface for the
> reason why).
> 
> Please add a comment to that effect when you commit the above.

Done.

Thanks!
-- 
Alan Third





  reply	other threads:[~2016-12-18 16:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17 19:54 bug#25219: 26.0.50; ispell failing jpff
2016-12-18 11:51 ` Alan Third
2016-12-18 15:18   ` Eli Zaretskii
2016-12-18 16:08     ` Alan Third [this message]
2016-12-18 16:57       ` Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161218160840.GA56991@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=25219-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).