From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Date: Thu, 15 Dec 2016 16:44:58 +0000 Message-ID: <20161215164458.GA2437@acm.fritz.box> References: <7cb86247-1e30-f029-0b9b-c53cc096ec4b@easy-emacs.de> <87mvggh2hu.fsf@users.sourceforge.net> <87h967cj0f.fsf@users.sourceforge.net> <87eg1bcg0y.fsf@users.sourceforge.net> <20161214215834.GB3881@acm.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1481820421 12791 195.159.176.226 (15 Dec 2016 16:47:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Dec 2016 16:47:01 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: 24870@debbugs.gnu.org, Matt Armstrong To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 15 17:46:54 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHZBF-0002FN-2j for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Dec 2016 17:46:53 +0100 Original-Received: from localhost ([::1]:55725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHZBJ-0003fL-EX for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Dec 2016 11:46:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHZAU-0003Ec-7v for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:46:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHZAQ-00074p-G5 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:46:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHZAQ-00074g-C2 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cHZAQ-0000DC-5D for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2016 11:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2016 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24870-submit@debbugs.gnu.org id=B24870.148182032330774 (code B ref 24870); Thu, 15 Dec 2016 16:46:02 +0000 Original-Received: (at 24870) by debbugs.gnu.org; 15 Dec 2016 16:45:23 +0000 Original-Received: from localhost ([127.0.0.1]:43141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHZ9m-000809-Pj for submit@debbugs.gnu.org; Thu, 15 Dec 2016 11:45:23 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:62788 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cHZ9l-0007xE-9l for 24870@debbugs.gnu.org; Thu, 15 Dec 2016 11:45:21 -0500 Original-Received: (qmail 59615 invoked by uid 3782); 15 Dec 2016 16:45:20 -0000 Original-Received: from acm.muc.de (p548C78B0.dip0.t-ipconnect.de [84.140.120.176]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 15 Dec 2016 17:45:19 +0100 Original-Received: (qmail 3068 invoked by uid 1000); 15 Dec 2016 16:44:58 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127062 Archived-At: Hello, Noam. On Thu, Dec 15, 2016 at 11:33:36AM -0500, Noam Postavsky wrote: > On Wed, Dec 14, 2016 at 4:58 PM, Alan Mackenzie wrote: > > Alas, that patch won't do. > I thought that might be the case. > > What is new here is characters with paren syntax also being components of > > 2-char comment delimiters. I recently fixed a similar problem when > > characters with word syntax were also flagged as 2-char comment delimiter > > parts. I think a similar patch at case label Sopen: (Line ~3322), which > > would peek ahead at the next character to check for "{-" before > > recognising the "{" as an open paren would be the best fix. > I don't think special casing Sopen makes sense, shouldn't the check > apply to all syntax classes? Maybe. I'm too tired to work this out at the moment (it was the office Glühwein day). > (the special case for word syntax does make sense, because it has its > own inner loop already) As does comment syntax, of course. > > Do you want to make this fix, or should I do it? If you want to do it, > > I'm willing (indeed, eager) to review it for you. > I'll have a patch ready in a day or two. Excellent! Or even in three or four days. Take your time, do it well (at least, better than I managed last time round) and enjoy doing it. -- Alan Mackenzie (Nuremberg, Germany).