From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#24966: 26.0.50; test-completion with alist COLLECTION calls PREDICATE incorrectly Date: Mon, 5 Dec 2016 20:50:38 -0500 Message-ID: <20161206015038.GA25281@holos.localdomain> References: <87shqnpxym.fsf@udel.edu> <87fumljw98.fsf@users.sourceforge.net> <87eg1wisck.fsf_-_@users.sourceforge.net> <20161128205917.GA17197@holos.localdomain> <878ts3hsh7.fsf@users.sourceforge.net> <20161130020415.GA23610@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1480989083 10240 195.159.176.226 (6 Dec 2016 01:51:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Dec 2016 01:51:23 +0000 (UTC) User-Agent: Mutt/1.7.1+65 (d6c10244793f) (2016-10-04) Cc: 24966@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 06 02:51:08 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cE4uS-0000wX-7W for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Dec 2016 02:51:08 +0100 Original-Received: from localhost ([::1]:45559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cE4uW-0003p9-2h for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Dec 2016 20:51:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cE4uQ-0003p2-0T for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2016 20:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cE4uM-0000Qa-VG for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2016 20:51:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cE4uM-0000QH-QL for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2016 20:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cE4uM-0002gw-Dr for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2016 20:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Dec 2016 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24966-submit@debbugs.gnu.org id=B24966.148098904810326 (code B ref 24966); Tue, 06 Dec 2016 01:51:02 +0000 Original-Received: (at 24966) by debbugs.gnu.org; 6 Dec 2016 01:50:48 +0000 Original-Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cE4u8-0002gT-4l for submit@debbugs.gnu.org; Mon, 05 Dec 2016 20:50:48 -0500 Original-Received: from mail-qk0-f169.google.com ([209.85.220.169]:34138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cE4u6-0002gG-0v for 24966@debbugs.gnu.org; Mon, 05 Dec 2016 20:50:46 -0500 Original-Received: by mail-qk0-f169.google.com with SMTP id q130so178456375qke.1 for <24966@debbugs.gnu.org>; Mon, 05 Dec 2016 17:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6icTuByubtECY+/RmwUwuIDo3f/RSq3LnEc07YrKxbc=; b=JtwseyDcThDX19CrMhB9jw+mNJSQEQsUra4VTc5+yNKupPIFh7/dq/h2cDCi/A0BVz iKYSksP7DnLpeGZESbNXfuGf64G8ju9kpY1fUGrc9p4CBpg7FF0ppcpD8hJeLaO9ghqi anerqHzVNWvS0TsE7Ui58RyGT+N2SOjwrci98P9rdytBOyCRzyZuobHHZlIqsmU1kawo xsFLTe5/rLpVCriVn2lj4FDolMDlr2w5uaCSl7Uy4QWTlNZjh5SbWF3VcmBEqaeGCptI QE8jJCIkn7B90sdxh+7OtQS7ejvEYNIGcHo9nKO8536bnNgx1yC/8P6g3OHReaqCcLZe ynZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6icTuByubtECY+/RmwUwuIDo3f/RSq3LnEc07YrKxbc=; b=XNjK+1k6FdAsrkpl3S1kaLt5khzDD6drtvqojrcmdQc4p4rrQAMOa5vn5kHBPI9Gn7 0O+NY6NwIuxNqYoNPXW6q05MYchX8YurF0V7i8fsaiHPkRH1G1ndkaxBY5CDi0zKUeib g0S0uWV9Ch2VwrcpPCbf6KGK40z8UF6yrc1HTP+5ZQnKSpIwmudwKmlwrf5R8wfZuPn0 2jBh/H7116MtdehPMbuGzb4OQuVka7lyk+8qwtGysQfUFHED8963S3lHtvbTB2LIIILj 8aA4xlA4unVpDyMygIa6JEInVvxX+d/xXnp68iapa2tKDz4O/7tWzZt3O4Qj8nwsKH8J XJsw== X-Gm-Message-State: AKaTC02gUENnTJ9fFJViFx0M+9ABTZbE/QisDozbdoMHoGeXiGjrLqPcPvL/jSOd0eS4OsX2 X-Received: by 10.55.175.198 with SMTP id y189mr50429840qke.293.1480989040284; Mon, 05 Dec 2016 17:50:40 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id r15sm10865485qte.9.2016.12.05.17.50.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2016 17:50:39 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 5923660D63; Mon, 5 Dec 2016 20:50:38 -0500 (EST) Content-Disposition: inline In-Reply-To: <20161130020415.GA23610@holos.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126539 Archived-At: On 29/11/16 at 09:04pm, Mark Oteiza wrote: > On 28/11/16 at 10:31pm, npostavs@users.sourceforge.net wrote: > > Noam Postavsky writes: > > > > > On Mon, Nov 28, 2016 at 3:59 PM, Mark Oteiza wrote: > > >>> > > >>> npostavs@users.sourceforge.net writes: > > >>> > > > >>> > I tentatively suggest the patch below, but I want to add some tests > > >>> > before commiting anything. > > >>> > > >>> While adding tests, I found another inconsistency: when given a > > >>> hashtable with symbol keys, test-completion passes the symbol-name to > > >>> PREDICATE, while all-completions and try-completion pass the original > > >>> symbol key. Here are two patches, the first for this bug, and the > > >>> second for the other inconsistency. > > >> > > >> The first hunk of 2/2 isn't applying here. > > > > > > Oh, that's probably because I generated it with -w, so some whitespace > > > changes are missing in 1/2. I'll post a full patch tonight. > > > > Here are the same patches with full whitespace changes. > > Thanks, all is well here with these patches Anything holding back applying these?