From: Mark Oteiza <mvoteiza@udel.edu>
To: npostavs@users.sourceforge.net
Cc: 24966@debbugs.gnu.org
Subject: bug#24966: 26.0.50; test-completion with alist COLLECTION calls PREDICATE incorrectly
Date: Mon, 5 Dec 2016 20:50:38 -0500 [thread overview]
Message-ID: <20161206015038.GA25281@holos.localdomain> (raw)
In-Reply-To: <20161130020415.GA23610@holos.localdomain>
On 29/11/16 at 09:04pm, Mark Oteiza wrote:
> On 28/11/16 at 10:31pm, npostavs@users.sourceforge.net wrote:
> > Noam Postavsky <npostavs@users.sourceforge.net> writes:
> >
> > > On Mon, Nov 28, 2016 at 3:59 PM, Mark Oteiza <mvoteiza@udel.edu> wrote:
> > >>>
> > >>> npostavs@users.sourceforge.net writes:
> > >>> >
> > >>> > I tentatively suggest the patch below, but I want to add some tests
> > >>> > before commiting anything.
> > >>>
> > >>> While adding tests, I found another inconsistency: when given a
> > >>> hashtable with symbol keys, test-completion passes the symbol-name to
> > >>> PREDICATE, while all-completions and try-completion pass the original
> > >>> symbol key. Here are two patches, the first for this bug, and the
> > >>> second for the other inconsistency.
> > >>
> > >> The first hunk of 2/2 isn't applying here.
> > >
> > > Oh, that's probably because I generated it with -w, so some whitespace
> > > changes are missing in 1/2. I'll post a full patch tonight.
> >
> > Here are the same patches with full whitespace changes.
>
> Thanks, all is well here with these patches
Anything holding back applying these?
next prev parent reply other threads:[~2016-12-06 1:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 10:26 bug#24966: 26.0.50; Mark Oteiza
2016-11-21 4:24 ` npostavs
2016-11-21 19:42 ` Mark Oteiza
2016-11-27 20:24 ` bug#24966: 26.0.50; test-completion with alist COLLECTION calls PREDICATE incorrectly npostavs
2016-11-28 20:59 ` Mark Oteiza
2016-11-28 21:03 ` Noam Postavsky
2016-11-29 3:31 ` npostavs
2016-11-30 2:04 ` Mark Oteiza
2016-12-06 1:50 ` Mark Oteiza [this message]
2016-12-07 3:31 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206015038.GA25281@holos.localdomain \
--to=mvoteiza@udel.edu \
--cc=24966@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).