From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#24966: 26.0.50; test-completion with alist COLLECTION calls PREDICATE incorrectly Date: Tue, 29 Nov 2016 21:04:15 -0500 Message-ID: <20161130020415.GA23610@holos.localdomain> References: <87shqnpxym.fsf@udel.edu> <87fumljw98.fsf@users.sourceforge.net> <87eg1wisck.fsf_-_@users.sourceforge.net> <20161128205917.GA17197@holos.localdomain> <878ts3hsh7.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1480471519 14090 195.159.176.226 (30 Nov 2016 02:05:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2016 02:05:19 +0000 (UTC) User-Agent: Mutt/1.7.1+60 (b22c5d0e299d) (2016-10-04) Cc: 24966@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 03:05:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBuGl-000292-Aw for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 03:05:11 +0100 Original-Received: from localhost ([::1]:40433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBuGn-0005ej-Df for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2016 21:05:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBuGh-0005dQ-KX for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2016 21:05:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBuGc-0000J3-I9 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2016 21:05:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cBuGc-0000Iv-CR for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2016 21:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cBuGc-0000Ao-4P for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2016 21:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2016 02:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24966-submit@debbugs.gnu.org id=B24966.1480471464620 (code B ref 24966); Wed, 30 Nov 2016 02:05:02 +0000 Original-Received: (at 24966) by debbugs.gnu.org; 30 Nov 2016 02:04:24 +0000 Original-Received: from localhost ([127.0.0.1]:46704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBuG0-00009v-42 for submit@debbugs.gnu.org; Tue, 29 Nov 2016 21:04:24 -0500 Original-Received: from mail-qk0-f178.google.com ([209.85.220.178]:34567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBuFy-00009j-Fm for 24966@debbugs.gnu.org; Tue, 29 Nov 2016 21:04:23 -0500 Original-Received: by mail-qk0-f178.google.com with SMTP id q130so7959679qke.1 for <24966@debbugs.gnu.org>; Tue, 29 Nov 2016 18:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xsMpXEsb+oO7mO5UEabXWnc1W6oarsbZEeE4uTgLg3g=; b=VcWNIUUgPNA8iyqUYeD9OWJeLm5YvTkoaHGsqyRbgBDgG/6I+zZS9Mrpt7GiQ4j3ab ezPTdIkTlbDVEkWb5YRG6By20wZSpjsesZy/w/V1I3lZPR6YBWSoXbHJKKlfxUSv1KML 4jpqnppT4jiaddoJ8u5O8KdyhXVAJUJ77Qguy44yVH+VEo0nqmmGz0cCOKIxIyyBHz3X LzB6D3YrhEN19hgov+76VuWvdILY+mXChh0MzSorXpFW4roU4e2lHCyq3u7eduiKIwHM b0ZWeiO8dY5hKzGIo1ebAwiPzFnPPlQ3FAODp9+U74jR1KdHyXWL2LqAfeTIZCIZD8qt Vc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xsMpXEsb+oO7mO5UEabXWnc1W6oarsbZEeE4uTgLg3g=; b=akyzMxcjm4OqIa6qzisNRvBaT2IfIPe5uV6PteLh+z4BIcIDEr8KWwVMkNK0L3HYjF ctgwKZoja3bQFFslch34xHmPW15uB4YHFw00RXpeQMeR7RqFTzTpsSW1OmVkykGSw9Fs fYo+vUmQxID4YhfbLmNG38f+3jWPUXG3ujQU+l8XPfBCCprHOWVv9gCSxIfd/kOpEvJF ohJQkF7WrZ2K72rVGAk2iLaZhLNWy6Gp0mE4YPo+tCiY7amS6zIRjgx5wP9Nyn44OcRQ E+cBQ694VdZq001wpTeYmKxlAwpczdBXasdIdmzGKaynutG7S6P3sdMKs3wosDT8EDAG oA9w== X-Gm-Message-State: AKaTC00ep/xrA851EVLDepmmLkQz08z7lgLgz6LgACy5NCFA3CzfUoXQ0JAfzUAxR/+wkOHe X-Received: by 10.55.74.1 with SMTP id x1mr28886809qka.316.1480471456961; Tue, 29 Nov 2016 18:04:16 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id 33sm32319895qtq.1.2016.11.29.18.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Nov 2016 18:04:15 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 3504860D62; Tue, 29 Nov 2016 21:04:15 -0500 (EST) Content-Disposition: inline In-Reply-To: <878ts3hsh7.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126283 Archived-At: On 28/11/16 at 10:31pm, npostavs@users.sourceforge.net wrote: > Noam Postavsky writes: > > > On Mon, Nov 28, 2016 at 3:59 PM, Mark Oteiza wrote: > >>> > >>> npostavs@users.sourceforge.net writes: > >>> > > >>> > I tentatively suggest the patch below, but I want to add some tests > >>> > before commiting anything. > >>> > >>> While adding tests, I found another inconsistency: when given a > >>> hashtable with symbol keys, test-completion passes the symbol-name to > >>> PREDICATE, while all-completions and try-completion pass the original > >>> symbol key. Here are two patches, the first for this bug, and the > >>> second for the other inconsistency. > >> > >> The first hunk of 2/2 isn't applying here. > > > > Oh, that's probably because I generated it with -w, so some whitespace > > changes are missing in 1/2. I'll post a full patch tonight. > > Here are the same patches with full whitespace changes. Thanks, all is well here with these patches