From: Mark Oteiza <mvoteiza@udel.edu>
To: Liu Hui <liuhui1610@gmail.com>
Cc: 24972-done@debbugs.gnu.org
Subject: bug#24972: 26.0.50; Multibyte characters are misaligned in ibuffer
Date: Tue, 22 Nov 2016 02:49:22 -0500 [thread overview]
Message-ID: <20161122074922.GA1616@holos.localdomain> (raw)
In-Reply-To: <6741c150-d985-26a3-5872-cd25e3b5ce02@gmail.com>
On 22/11/16 at 02:54pm, Liu Hui wrote:
>
> 在 2016年11月22日 13:12, Mark Oteiza 写道:
> > On 22/11/16 at 11:51am, Liu Hui wrote:
> > > Thank you, but the trailing "..." is missing for long buffer names, no
> > > matter whether they contain multibyte characters. For example,
> > > "01234567890123456789" becomes "012345678901234567". The normal result
> > > should be "012345678901234...".
> >
> > Would you try the following?
> >
> > diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
> > index faadb67..c550b7d 100644
> > --- a/lisp/ibuffer.el
> > +++ b/lisp/ibuffer.el
> > @@ -1559,16 +1559,17 @@ ibuffer-compile-make-eliding-form
> > `(concat ,ellipsis
> > (substring ,strvar
> > (string-width ibuffer-eliding-string)))
> > - `(truncate-string-to-width
> > - ,strvar strlen nil nil
> > - ,ellipsis))
> > + `(concat
> > + (truncate-string-to-width
> > + ,strvar (- strlen (string-width ,ellipsis)) nil ?.)
> > + ,ellipsis))
> > ,strvar)
> > strvar)))
> >
> > (defun ibuffer-compile-make-substring-form (strvar maxvar from-end-p)
> > (if from-end-p
> > - `(truncate-string-to-width str (string-width str) (- strlen ,maxvar))
> > - `(truncate-string-to-width ,strvar ,maxvar)))
> > + `(truncate-string-to-width str (string-width str) (- strlen ,maxvar) nil ?\s)
> > + `(truncate-string-to-width ,strvar ,maxvar nil ?\s)))
> >
> > (defun ibuffer-compile-make-format-form (strvar widthform alignment)
> > (let* ((left `(make-string tmp2 ?\s))
> >
>
> It works very well. Thank you.
Wahoo! Pushed, thanks.
prev parent reply other threads:[~2016-11-22 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 12:32 bug#24972: 26.0.50; Multibyte characters are misaligned in ibuffer Liu Hui
2016-11-20 18:58 ` Mark Oteiza
2016-11-21 6:00 ` Liu Hui
2016-11-21 9:35 ` Mark Oteiza
2016-11-22 3:51 ` Liu Hui
2016-11-22 5:12 ` Mark Oteiza
2016-11-22 6:54 ` Liu Hui
2016-11-22 7:49 ` Mark Oteiza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122074922.GA1616@holos.localdomain \
--to=mvoteiza@udel.edu \
--cc=24972-done@debbugs.gnu.org \
--cc=liuhui1610@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).