From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#24972: 26.0.50; Multibyte characters are misaligned in ibuffer Date: Mon, 21 Nov 2016 04:35:45 -0500 Message-ID: <20161121093545.GA1654@holos.localdomain> References: <87bmxa2d2v.fsf@udel.edu> <39442582-6036-47de-1a7a-4d46e43496c1@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1479720974 25323 195.159.176.226 (21 Nov 2016 09:36:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Nov 2016 09:36:14 +0000 (UTC) User-Agent: Mutt/1.7.1+41 (5382e1e4cee1) (2016-10-04) Cc: 24972@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 21 10:36:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8l1F-0005Ub-8Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 10:36:09 +0100 Original-Received: from localhost ([::1]:48285 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8l1H-000531-08 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 04:36:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8l1B-00052e-9K for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 04:36:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8l18-0002rU-42 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 04:36:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49513) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8l17-0002rJ-VG for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 04:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c8l17-0003OL-NC for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 04:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2016 09:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24972 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24972-submit@debbugs.gnu.org id=B24972.147972095413024 (code B ref 24972); Mon, 21 Nov 2016 09:36:01 +0000 Original-Received: (at 24972) by debbugs.gnu.org; 21 Nov 2016 09:35:54 +0000 Original-Received: from localhost ([127.0.0.1]:36679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8l10-0003Nz-4x for submit@debbugs.gnu.org; Mon, 21 Nov 2016 04:35:54 -0500 Original-Received: from mail-qk0-f176.google.com ([209.85.220.176]:35902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8l0y-0003Nn-Cn for 24972@debbugs.gnu.org; Mon, 21 Nov 2016 04:35:52 -0500 Original-Received: by mail-qk0-f176.google.com with SMTP id n21so342375025qka.3 for <24972@debbugs.gnu.org>; Mon, 21 Nov 2016 01:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=dSkvQauWOR7vsF6TaFq1v2moeEvNqDCyzsY7lmztTmI=; b=Y/fLv3t9LsSNpSaxVYX645/ubFsJrTRZBIOyRdWYAXjSOX4+OmCBp3IcUeRnwhwItR lmqTkdYthojvzu31u3VirQjvY9VpS1r6S3PzB8lRvWo2lW1BEpGZGwfBIVibzn6P88yB pxBNWUpWe/2c/5vHi+Gvue7yQoc28h/OS50jvo5d1VdCrGmrQx+kFXUEoTLt37kSJ2N5 Z6pPnb7AzpevP7/hm5AMNjpqUnhOYjAurBkXxqYfH3llfLmd70S+OY51EPq56cJ7Evgq SxW0OHbZQtDlrpVCqZbR0DxpEISINnHnAoMVd6q89yuCc5VJsQ2J9sIhuKbHH38mZwk8 yIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=dSkvQauWOR7vsF6TaFq1v2moeEvNqDCyzsY7lmztTmI=; b=aShb92xwmuhVWITdLNFU4QHgDvQiBYldM6cylHfLE7ry1KgaffJunTwWuE6y2f/iBp 1I6a39g3trmDkgpgjNO2uG6B6S0qtBwe2QO7Eq+VhGsZq5peBSBg/SQ90C930NrjP9ZT UcIwKx3wL5N1QAqJ85I/kUPgbR1so+IpSwc/PxUnflXNfxCB0OtIsso7RkcAPGkyrEUk ti3h+yjNYjRwj+AddclDXbxbCl/DdPNlvZZS9EWuILWJStBXwywZjp+CKqmNYfNuuhSm H8g+w2M1F6JXygyH+TnPrKAB9oU796+ttomzWS16J3Txz6dmp3HkpUHZy5G053l4bxBi ExvQ== X-Gm-Message-State: AKaTC010A8jiEpFAxGnMcZD677lNACVajZAMh5Yuzd2aWbJKwExqbSHeGK2KeeSZhOSxBUwQ X-Received: by 10.55.118.65 with SMTP id r62mr15984092qkc.21.1479720946835; Mon, 21 Nov 2016 01:35:46 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id a69sm10729269qkj.38.2016.11.21.01.35.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2016 01:35:46 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 6B8416613E; Mon, 21 Nov 2016 04:35:45 -0500 (EST) Content-Disposition: inline In-Reply-To: <39442582-6036-47de-1a7a-4d46e43496c1@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125939 Archived-At: On 21/11/16 at 02:00pm, Liu Hui wrote: > 在 2016年11月21日 02:58, Mark Oteiza 写道: > > Liu Hui writes: > > > As shown in the screenshot attached, multibyte characters (the second > > > line) are misaligned in ibuffer. The problem seems at least relevant > > > to the function `ibuffer-compile-format', which uses `length' rather > > > than `string-width' for characters. > > > > Indeed, changing to string-width improves it. ibuffer should probably > > also be using display properties to align the columns, but that's > > another issue. > > > > Committed in 7e2a8b1. Thanks for reporting > > Thank you, but I find it does not work when the multibyte string is long. > For example, if the string-width of buffer name, e.g. > "一个很长很长的文件名", exceeds the default width of ibuffer column, M-x > ibuffer will fail and issue an error. > > According to the backtrace, it is because `ibuffer-compile-format' calls > `ibuffer-compile-make-substring-form'/`ibuffer-compile-make-eliding-form', > which use `substring' to truncate the multibyte string. A similar issue was > reported in https://github.com/emacs-helm/helm/issues/170. Probably > replacing `substring' solves the problem. Ah, thanks. I pushed another change that fixes the error. Still, if the name is a particular mix of half- and full-width though (e.g. "aーーーーーー"), the next column(s) might be off by one.