From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#24580: 25.2.50; query-replace history doesn't work Date: Sun, 2 Oct 2016 00:17:15 -0400 Message-ID: <20161002041715.GA5612@holos.localdomain> References: <87fuogh8mo.fsf@mbork.pl> <83y428lawc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1475381912 23114 195.159.176.226 (2 Oct 2016 04:18:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2016 04:18:32 +0000 (UTC) User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) Cc: Marcin Borkowski , 24580@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 02 06:18:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqYEC-0003vh-Rw for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 06:18:17 +0200 Original-Received: from localhost ([::1]:57977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqYEB-0005UT-9Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 00:18:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqYE2-0005UL-PQ for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 00:18:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqYDy-000688-Hd for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 00:18:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqYDy-000684-Dl for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 00:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqYDy-0007LG-1D for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 00:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2016 04:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24580 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24580-submit@debbugs.gnu.org id=B24580.147538184428176 (code B ref 24580); Sun, 02 Oct 2016 04:18:01 +0000 Original-Received: (at 24580) by debbugs.gnu.org; 2 Oct 2016 04:17:24 +0000 Original-Received: from localhost ([127.0.0.1]:41431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqYDM-0007KO-Lx for submit@debbugs.gnu.org; Sun, 02 Oct 2016 00:17:24 -0400 Original-Received: from mail-qt0-f179.google.com ([209.85.216.179]:33521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqYDK-0007KB-Kk for 24580@debbugs.gnu.org; Sun, 02 Oct 2016 00:17:23 -0400 Original-Received: by mail-qt0-f179.google.com with SMTP id 11so68039483qtc.0 for <24580@debbugs.gnu.org>; Sat, 01 Oct 2016 21:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=U4zgfc3zCSvenh0ZXJ5HPEs/i5K/we3VtqrpDneNag0=; b=mh19euVfTEiI1PCM+qKEyc6axnH1BQOtF3+k3ohA9504V/MDUnnbmFljHPJwfydOMM Id8wwl8CcvxgZZSKtZ1dtfwkj2GpnE9fbPKOO2xn35XsIbTuEeAxSiOxSEuvR2V8GS+8 vwZux2oO5b6IfAb9gSfY4ZxeNy1zvc0z71VTuzUHoa9nplX5PEdHkHrc5RadDeRCYHuk CRk0vwefPRYDTy6OWBdjKCxdEZ+yo/UPQ0MtQrMeWVVtFSb1gnwC8RnkVBjX7g6fd9ic aa6g9keXID8QqNHKtsSh/JjSPRdog9uma7X1jfJxqdfF0fAQHm0UCg0y8HWQTIg+YsDF 3P5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=U4zgfc3zCSvenh0ZXJ5HPEs/i5K/we3VtqrpDneNag0=; b=gJe7AtSImTSQVhO06WYzcqLjS/siOv8EZYPZ7YHgogx3pHW8hZO3qZ6JRiyH/BCyF6 7w3PWNs/TMjYNm1nyNfzSCJhZSMhimIjqO8bOcEb+UzfBBCU9E4NguvE/MQ1mS1xppen pjO4jrQiEvh9KdBQ42z0h3ERECU92tYe6mVRuxj/+fgBUwcenkI2QnjYG2LcM1dQzoG6 VhoC5E+2lM2tEpjYcN5DF3rIC8WBGNdV+zX7MOWYQymRsVOfWCZpZNCT5dMHC8oa52VP S43xn8HqX180hv/WHlMLXLncncBiBGMx5h6XE8XqWkVVWEzxmj0XZlAH6/2xIlaui5KR XnpA== X-Gm-Message-State: AA6/9Rnp6SCL7pYXc+8+7mJE45gxgT70xJ+O6u0nIBSNSJ/MfxSPFxILolmVEfvgbuCpLAlx X-Received: by 10.200.54.149 with SMTP id a21mr13879983qtc.126.1475381837137; Sat, 01 Oct 2016 21:17:17 -0700 (PDT) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id x201sm14452339qkx.32.2016.10.01.21.17.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Oct 2016 21:17:16 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 6081260D6C; Sun, 2 Oct 2016 00:17:15 -0400 (EDT) Content-Disposition: inline In-Reply-To: <83y428lawc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123883 Archived-At: On 01/10/16 at 11:40am, Eli Zaretskii wrote: > > From: Marcin Borkowski > > Date: Sat, 01 Oct 2016 08:43:27 +0200 > > > > - start emacs -Q > > - press `a' `C-b', `M-%', `a', `RET', `b', `RET', `!' > > - press `M-%', `M-p' > > > > Emacs says "Beginning of history; no preceding item". > > Mark, this regression was caused by the lexical-binding change in > replace.el. Could you please take a look? The problem lies (at least) in query-replace-read-from, where query-replace-from-to is let bound, and later read-from-minibuffer refers to the symbol 'query-replace-from-to. At first sight, it looks like it could be fixed by putting some of the setup done by these bindings into the minibuffer setup hook. As for the other problem Marcin mentioned, that seems to be due to the custom-reevaluate-setting call in the same function.