From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Date: 23 Sep 2016 18:47:59 -0000 Organization: muc.de e.V. Message-ID: <20160923184759.30985.qmail@mail.muc.de> References: <20160922231447.GA3833@odonien.localdomain> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1474656573 1694 195.159.176.226 (23 Sep 2016 18:49:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2016 18:49:33 +0000 (UTC) User-Agent: tin/2.3.1-20141224 ("Tallant") (UNIX) (FreeBSD/10.3-RELEASE-p7 (amd64)) Cc: 24514@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 23 20:49:29 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnVX8-0006Ki-51 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 20:49:14 +0200 Original-Received: from localhost ([::1]:49812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnVX5-00032T-8V for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 14:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnVWy-00031L-PV for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 14:49:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnVWw-0001dl-1w for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 14:49:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnVWv-0001dh-UP for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 14:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bnVWv-0006lB-Q6 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 14:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 18:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24514 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24514-submit@debbugs.gnu.org id=B24514.147465648225917 (code B ref 24514); Fri, 23 Sep 2016 18:49:01 +0000 Original-Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 18:48:02 +0000 Original-Received: from localhost ([127.0.0.1]:33693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnVVy-0006jx-A8 for submit@debbugs.gnu.org; Fri, 23 Sep 2016 14:48:02 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:33488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnVVw-0006jX-Gr for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 14:48:01 -0400 Original-Received: (qmail 30986 invoked by uid 3782); 23 Sep 2016 18:47:59 -0000 In-Reply-To: X-Newsgroups: gnu.emacs.bug X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123609 Archived-At: In article you wrote: > [-- text/plain, encoding 7bit, charset: utf-8, 30 lines --] > I wrote a minimal patch that increases the overall consistency in a > backtrace buffer by printing the call stack frames as S-Expressions. > Before: > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) > +(1 t) > eval((+ 1 t) nil) > eval-expression((+ 1 t) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) > After: > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) > (debug error (wrong-type-argument number-or-marker-p t)) > (+ 1 t) > (eval (+ 1 t) nil) > (eval-expression (+ 1 t) nil) > (funcall-interactively eval-expression (+ 1 t) nil) > (call-interactively eval-expression nil nil) > (command-execute eval-expression) I'm not sure I'm in favour of this change. There is some tool in some circumstances which prints the lines in the "before:" fashion interspersed with internal forms from function which start off with "(" in column 0. Having the distinction between lines starting with "(" and lines starting with the function name is handy for telling them apart. Sorry I can't be more specific about the circumstances this happens in, but it happens relatively frequently. > Now, this patch isn't perfect. For some reason there's an extra debug > line in the second version, I've yet to investigate into the reason for > this. The other problem is that while I can't imagine any reason to go > back to the original view of the backtrace, I cannot rule out that this > change might break other tools relying on it. I'd appreciate any > feedback on this. -- Alan Mackenzie (Nuremberg, Germany).