From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#24514: 24.5; [WIP][PATCH] Lispy backtraces Date: Fri, 23 Sep 2016 10:12:35 +0200 Message-ID: <20160923081235.GA644@odonien.localdomain> References: <20160922231447.GA3833@odonien.localdomain> <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="y0ulUmNC+osPPQO6" X-Trace: blaine.gmane.org 1474622979 9160 195.159.176.226 (23 Sep 2016 09:29:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2016 09:29:39 +0000 (UTC) User-Agent: Mutt/1.7.0 (2016-08-17) To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel , 24514@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 23 11:29:35 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnMnS-0001Uu-8y for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 11:29:30 +0200 Original-Received: from localhost ([::1]:42971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnMnQ-0002FD-Ji for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2016 05:29:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnLcV-00045b-1v for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 04:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnLcQ-0006do-LM for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 04:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnLcQ-0006di-HS for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 04:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bnLcQ-0006KB-Du for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2016 04:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2016 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24514 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24514-submit@debbugs.gnu.org id=B24514.147461838524226 (code B ref 24514); Fri, 23 Sep 2016 08:14:02 +0000 Original-Received: (at 24514) by debbugs.gnu.org; 23 Sep 2016 08:13:05 +0000 Original-Received: from localhost ([127.0.0.1]:33047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLbU-0006Ig-Qg for submit@debbugs.gnu.org; Fri, 23 Sep 2016 04:13:04 -0400 Original-Received: from mail-wm0-f42.google.com ([74.125.82.42]:35147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnLbT-0006IC-FD for 24514@debbugs.gnu.org; Fri, 23 Sep 2016 04:13:03 -0400 Original-Received: by mail-wm0-f42.google.com with SMTP id l132so16235260wmf.0 for <24514@debbugs.gnu.org>; Fri, 23 Sep 2016 01:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B9rW3ibZw/roH1eLGkbLqPKizZr7Yoo05HpgET4YzyE=; b=np+72XMWzEJD4oZx/4lRZQpyo172bKbB1h1FiFFsz2AS2VN/8IHxvrQICADubqIMJA wSkvVf4PRKcbVAGIwNdWUB1OCfBw7teYDtT131xrdCrlI+iNIAQYpSW4HvgY5BxB78mM oNFhvzvvsa8llOxfRfpWMTbn8IXPCD2b73mmx1QS/FEA/B7TKOe3gE/GtXlQ5K2XWnCP xtSA6OI0yPe731dpGGQt1qhSSBWagvk7f5BA3SCsRB6sSxWA70fgGkxfoT//kWuLHiJQ ouJxpUiLlMtEGhUR0buDxI30L+sjRH51puz/MsHEphlcpbqi6QtriQzIF7aKkEc88GDG +Liw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B9rW3ibZw/roH1eLGkbLqPKizZr7Yoo05HpgET4YzyE=; b=Rbom8N3K8yzqzcKnP7VzhOAMKxsPmsXqEYkTAFoecDoTevdovq/pVpeRJJvJih6n27 YF27+NsUamlhh1YjSh5Qx3yc63u2WR7ujisYU7KvRe6Iqypxcruc8DrOsvficAtnFf8G T/XEt4Y0ZeaotobYhkr0paTGNlqqDc1iCmwGuuj67MbZ7IjztBkvO3gpUcsd/BY898O3 0kEiU1eEetMNPZkdkYDw9dRqoIgSg9wlngaNQekWuzTuVbbI8xsTBLateZkRCdBgkItd hOV0uAAwA739o+PPkup6uPRRDMaLt7lr6+pvc4+rFmTNtNK0zHLSpLxoZ0bKu1sfWhyV +FOg== X-Gm-Message-State: AE9vXwPSnMUpPK1byHMaUrRIbYlSU2n0xG41cQyj5xrBj1MyBNdwkQtsJLkk44glsGT0Uw== X-Received: by 10.194.93.8 with SMTP id cq8mr5574106wjb.10.1474618377812; Fri, 23 Sep 2016 01:12:57 -0700 (PDT) Original-Received: from localhost ([2.160.70.242]) by smtp.gmail.com with ESMTPSA id xb6sm5959155wjb.30.2016.09.23.01.12.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Sep 2016 01:12:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <98fbb582-3da4-bd83-a2e9-e341dd7f6140@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123589 Archived-At: --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Ouch, forgot the attachment. --y0ulUmNC+osPPQO6 Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Make-backtraces-great-again.patch" >From f85845921c5e06475c925508ba41b06340f4c95a Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Thu, 22 Sep 2016 23:01:21 +0200 Subject: [PATCH] Make backtraces great again --- lisp/emacs-lisp/debug.el | 2 +- src/eval.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 22a3f39..a1ca336 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -279,7 +279,7 @@ That buffer should be current already." (goto-char (point-min)) (delete-region (point) (progn - (search-forward "\n debug(") + (search-forward "\n (debug ") (forward-line (if (eq (car args) 'debug) ;; Remove debug--implement-debug-on-entry ;; and the advice's `apply' frame. diff --git a/src/eval.c b/src/eval.c index 72facd5..698e0a1 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3409,13 +3409,13 @@ Output stream used is value of `standard-output'. */) else { tem = backtrace_function (pdl); - Fprin1 (tem, Qnil); /* This can QUIT. */ write_string ("("); + Fprin1 (tem, Qnil); /* This can QUIT. */ { ptrdiff_t i; for (i = 0; i < backtrace_nargs (pdl); i++) { - if (i) write_string (" "); + write_string (" "); Fprin1 (backtrace_args (pdl)[i], Qnil); } } -- 2.9.3 --y0ulUmNC+osPPQO6--