From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#23462: [PATCH] Block input while minimizing on NS (bug#23462) Date: Thu, 12 May 2016 12:52:43 +0100 Message-ID: <20160512115243.GA53583@breton.holly.idiocy.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1463054015 10446 80.91.229.3 (12 May 2016 11:53:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 May 2016 11:53:35 +0000 (UTC) Cc: 23462@debbugs.gnu.org, Ivan Cibrario Bertolotti To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 12 13:53:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0pB7-0007kQ-SV for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 May 2016 13:53:18 +0200 Original-Received: from localhost ([::1]:56999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0pB4-0003WH-5B for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 May 2016 07:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0pAw-0003Oo-EZ for bug-gnu-emacs@gnu.org; Thu, 12 May 2016 07:53:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0pAs-0007FM-6T for bug-gnu-emacs@gnu.org; Thu, 12 May 2016 07:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0pAs-0007FH-23 for bug-gnu-emacs@gnu.org; Thu, 12 May 2016 07:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0pAr-000165-Pl for bug-gnu-emacs@gnu.org; Thu, 12 May 2016 07:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 May 2016 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23462-submit@debbugs.gnu.org id=B23462.14630539734203 (code B ref 23462); Thu, 12 May 2016 11:53:01 +0000 Original-Received: (at 23462) by debbugs.gnu.org; 12 May 2016 11:52:53 +0000 Original-Received: from localhost ([127.0.0.1]:48103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0pAj-00015j-6F for submit@debbugs.gnu.org; Thu, 12 May 2016 07:52:53 -0400 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:35025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0pAh-00015V-5U for 23462@debbugs.gnu.org; Thu, 12 May 2016 07:52:51 -0400 Original-Received: by mail-wm0-f53.google.com with SMTP id e201so255176094wme.0 for <23462@debbugs.gnu.org>; Thu, 12 May 2016 04:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zXaObrvCnedDGYS1cHxzbMU/o2K3JJdQxlZfgXvwlUE=; b=kjqn5kjTMHICJUfeun6AUN+KJQcMCbilrKVJWS6esPza6CR1Kiq4u4VmetOMw6JYZi KV+ER1DiiNByaRenHXuoD3v/wBdYqYB0ZdP2iVcy/Jh0TEiO6i7LLidwmJPguGEH2JB6 J32mfibwtE9qKxfO87KodJU/S1lTX+GcJD+2vIGI5AckU5WRqXWxMaAWs5LdhuhUlKN8 Xl2YWA05Wi0e3crlvFdlHII5nofrGDEA5om6B2qN8oLL1Rnw+SWfgdM7fLz2kems9oFV 3T375eDWEKE8vk+M2tYCZX15MKQWNS7+fcN33n1V8bYUm6hiIQREhbePOumngrEAn7UW H+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=zXaObrvCnedDGYS1cHxzbMU/o2K3JJdQxlZfgXvwlUE=; b=kD0cFbR7P8aB8iTgGrWmRdnABJo+IOD5OCEV3AhqY/X4n3ukNglxJbmgqQuwJxbDoq KGdfPADS2oG6KhZYInWUVvaf/vlPXMgjpWxB8iSJkyE6+NFnp7NmaV/O/eJMw0E2Wt6U i4f08cUy4Iwnf/V593ScA4JJJWyHn5UBnTM6GhbwXb8ps3BS4H7EKtPUMhJ4UxqMFteV PKv3C7cf7K1RnAi7sLnY608cDbTPF++yDdm3F67flHGWUszZPEGAC2rqiGjCsDbe3Bes pl/5cM01Z9ydc/sWLQpl1zU+BwBWBCP8kW6h6Kal9RI0TohVQgw/9KZ4XtbZ6LGw4inb pBNA== X-Gm-Message-State: AOPr4FXGeMtihFX5Vp61duGrqquA3/ZOlFE0X1cKi+5G898hTHi5HifvliDAab/p6Ld0zg== X-Received: by 10.28.47.208 with SMTP id v199mr5990461wmv.56.1463053965397; Thu, 12 May 2016 04:52:45 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3074-8e50-2562-9a84.holly.idiocy.org. [2001:8b0:3f8:8129:3074:8e50:2562:9a84]) by smtp.gmail.com with ESMTPSA id w3sm13073775wjt.0.2016.05.12.04.52.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 May 2016 04:52:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118162 Archived-At: * src/nsterm.m (x_iconify_frame): Block input while miniaturize is running. --- src/nsterm.m | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/nsterm.m b/src/nsterm.m index 1d48c04..840c9c1 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -1612,7 +1612,12 @@ static void hide_bell () [[view window] orderOut: NSApp]; [[view window] setFrame: t display: NO]; } + + /* Processing input while Emacs is being minimized can cause a + crash, so block it for the duration. */ + block_input(); [[view window] miniaturize: NSApp]; + unblock_input(); } /* Free X resources of frame F. */ -- I've tried this on GNUStep as well and it doesn't break it any more than it's already broken. -- Alan Third