From: Alan Third <alan@idiocy.org>
To: Anders Lindgren <andlind@gmail.com>
Cc: 23462@debbugs.gnu.org,
Ivan Cibrario Bertolotti <ivan.cibrario@polito.it>
Subject: bug#23462: [PATCH] Block input while minimizing on NS (bug#23462)
Date: Thu, 12 May 2016 12:52:43 +0100 [thread overview]
Message-ID: <20160512115243.GA53583@breton.holly.idiocy.org> (raw)
In-Reply-To: <CABr8ebY6GeWm2AKW-5_zJgw3q6awCdZ4OUYr1tpm8Vbzp7wVcg@mail.gmail.com>
* src/nsterm.m (x_iconify_frame): Block input while miniaturize is
running.
---
src/nsterm.m | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/nsterm.m b/src/nsterm.m
index 1d48c04..840c9c1 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -1612,7 +1612,12 @@ static void hide_bell ()
[[view window] orderOut: NSApp];
[[view window] setFrame: t display: NO];
}
+
+ /* Processing input while Emacs is being minimized can cause a
+ crash, so block it for the duration. */
+ block_input();
[[view window] miniaturize: NSApp];
+ unblock_input();
}
/* Free X resources of frame F. */
--
I've tried this on GNUStep as well and it doesn't break it any more
than it's already broken.
--
Alan Third
next prev parent reply other threads:[~2016-05-12 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 21:25 bug#23462: 25.0.93; Crash on OS X when suspending main frame Ivan Cibrario Bertolotti
2016-05-08 9:53 ` Alan Third
2016-05-08 15:58 ` Eli Zaretskii
2016-05-08 16:56 ` Ivan Cibrario Bertolotti
2016-05-08 22:41 ` Alan Third
2016-05-09 8:49 ` Ivan Cibrario Bertolotti
2016-05-10 18:56 ` Anders Lindgren
2016-05-10 20:13 ` Ivan Cibrario Bertolotti
2016-05-10 21:57 ` Anders Lindgren
2016-05-10 22:08 ` Alan Third
2016-05-10 23:16 ` Alan Third
2016-05-11 22:28 ` Alan Third
2016-05-12 5:39 ` Anders Lindgren
2016-05-12 11:52 ` Alan Third [this message]
2016-05-12 16:38 ` bug#23462: [PATCH] Block input while minimizing on NS (bug#23462) Ivan Cibrario Bertolotti
2016-05-12 18:28 ` Anders Lindgren
2016-05-16 18:45 ` Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512115243.GA53583@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=23462@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=ivan.cibrario@polito.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).