unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: 22973@debbugs.gnu.org
Subject: bug#22973: [PATCH] Enable dividers in NS (bug#22973)
Date: Wed, 4 May 2016 22:42:04 +0100	[thread overview]
Message-ID: <20160504214204.GA39118@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2mvq7gjt1.wl%esq@lawlist.com>

src/nsfns.m: Add colour settings functions to ns_frame_park_handlers.
src/nsterm.m (ns_draw_window_divider): ns_focus has to go before the
attempt to set the colour.
src/nsterm.m (ns_draw_vertical_window_border): This had the same bug as
above, although I didn't see any errors.
---
 src/nsfns.m  | 4 ++--
 src/nsterm.m | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/nsfns.m b/src/nsfns.m
index ea09908..9291f8e 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -983,8 +983,8 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side
   x_set_icon_name,
   x_set_icon_type,
   x_set_internal_border_width, /* generic OK */
-  0, /* x_set_right_divider_width */
-  0, /* x_set_bottom_divider_width */
+  x_set_right_divider_width,
+  x_set_bottom_divider_width,
   x_set_menu_bar_lines,
   x_set_mouse_color,
   x_explicitly_set_name,
diff --git a/src/nsterm.m b/src/nsterm.m
index 1d48c04..438054f 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -2951,10 +2951,11 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
   NSTRACE ("ns_draw_vertical_window_border");
 
   face = FACE_FROM_ID (f, VERTICAL_BORDER_FACE_ID);
+
+  ns_focus (f, &r, 1);
   if (face)
       [ns_lookup_indexed_color(face->foreground, f) set];
 
-  ns_focus (f, &r, 1);
   NSRectFill(r);
   ns_unfocus (f);
 }
@@ -2973,10 +2974,11 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
   NSTRACE ("ns_draw_window_divider");
 
   face = FACE_FROM_ID (f, WINDOW_DIVIDER_FACE_ID);
+
+  ns_focus (f, &r, 1);
   if (face)
       [ns_lookup_indexed_color(face->foreground, f) set];
 
-  ns_focus (f, &r, 1);
   NSRectFill(r);
   ns_unfocus (f);
 }
-- 
2.7.4


-- 
Alan Third





  parent reply	other threads:[~2016-05-04 21:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10  2:15 bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky
2016-03-10 10:32 ` martin rudalics
2016-03-11  7:02 ` Keith David Bershatsky
2016-05-04 21:42 ` Alan Third [this message]
2016-05-16  8:20   ` bug#22973: [PATCH] Enable dividers in NS (bug#22973) martin rudalics
2016-06-27 22:02   ` Alan Third
2017-11-19  2:55 ` bug#22973: OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160504214204.GA39118@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=22973@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).