From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: yary <not.com@gmail.com>,
23407@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#23407: .dir-local settings get obliterated on running a major mode function.
Date: Mon, 2 May 2016 07:10:15 +0000 [thread overview]
Message-ID: <20160502071015.GA2048@acm.fritz.box> (raw)
In-Reply-To: <jwv4mahgldr.fsf-monnier+emacsbugs@gnu.org>
Hello, Stefan.
Thanks for looking at my patch.
On Mon, May 02, 2016 at 12:02:11AM -0400, Stefan Monnier wrote:
> > Anyhow, I've hacked a patch together. The idea is to call
> > `hack-local-variables' from `run-mode-hooks' rather than from
> > `normal-mode'.
> Good idea.
> > + ;; delay-mode-hooks is set when `byte-compile-file' is the caller.
> > + ;; It is essential that we call `hack-local-variables' in order to
> > + ;; set up `lexical-binding', since `run-mode-hooks' is prevented
> > + ;; from doing its job.
> > + (when delay-mode-hooks
> > + (with-demoted-errors "File local-variables error: %s"
> > + (hack-local-variables 'no-mode))))
> But this seems terribly brittle. Do we care about delay-mode-hooks (as
> the code says) or about byte-compile-file (as the comment says)?
This bit of code was necessitated by:
#########################################################################
commit 3ba6b3a9c1e0565ee5f45f11a9c09702a24f8453
Author: Artur Malabarba <bruce.connor.am@gmail.com>
Date: Sun Apr 12 03:23:35 2015 +0100
Speed up byte-compilation and autoload generation by avoiding mode-hooks
This prevents emacs-lisp-mode-hook from being run everytime an
autoload file is generated, which can account for a fraction of
package installation time depending on the hooks the user has
configured.
* lisp/emacs-lisp/bytecomp.el (byte-compile-file): Use
* delay-mode-hooks.
* lisp/emacs-lisp/autoload.el (autoload-find-file)
(autoload-find-generated-file): Use delay-mode-hooks.
#########################################################################
if hack-local-variables isn't run, lexical-binding (for example) doesn't
get set up, and make bootstrap fails.
> If it's the former, then the comment needs to be fixed, if it's the
> latter, than we need to find some other way to tell this code what's
> going on.
I don't really understand the question. Sure, that bit of code is ugly.
But the comment both motivates ("it's `byte-compile-file''s fault") and
explains the problem (which is that `delay-mode-hooks' being set would
prevent `run-mode-hook', and thus `hack-local-variable' from running).
It is possible that other stuff might call `normal-mode' like this.
What sort of changes do you advocate for the comment (or for the code)?
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-05-02 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 10:27 bug#23407: .dir-local settings get obliterated on running a major mode function Alan Mackenzie
2016-04-30 10:53 ` Dmitry Gutov
2016-04-30 18:50 ` Glenn Morris
2016-04-30 18:53 ` Glenn Morris
2016-05-01 21:28 ` Alan Mackenzie
2016-05-02 4:02 ` Stefan Monnier
2016-05-02 7:10 ` Alan Mackenzie [this message]
2016-05-03 18:10 ` Stefan Monnier
2016-05-05 11:39 ` Alan Mackenzie
2016-05-05 12:54 ` Stefan Monnier
[not found] ` <mailman.1598.1462012164.7477.bug-gnu-emacs@gnu.org>
2016-05-05 11:24 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502071015.GA2048@acm.fritz.box \
--to=acm@muc.de \
--cc=23407@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
--cc=not.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).