unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Etienne Prud'homme" <yuicopr@gmail.com>
To: 23384@debbugs.gnu.org
Subject: bug#23384: [PATCH] Support completion of color functions in CSS mode
Date: Tue, 26 Apr 2016 18:46:18 -0400	[thread overview]
Message-ID: <20160426184618.5d8fd906@ThinkPax> (raw)

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

The attached patch adds completion for CSS color functions such as
`rgb()'. Values were taken from the “CSS Color Module Level 4”. It can
be found at: https://drafts.csswg.org/css-color/#color-type

As a sidenote, how should we handle functions? Since they use
parentheses, the point is going to be outside of parentheses.

Eg.
rgba()*
      ^(point)

Also, should we include the parameters number?

[-- Attachment #2: 0001-Add-completion-of-color-functions-in-CSS-mode.patch --]
[-- Type: text/x-patch, Size: 1202 bytes --]

From 52cc18080206fcd0d154a6c75c458a39bdcdfcbc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Etienne=20Prud=E2=80=99homme?= <e.e.f.prudhomme@gmail.com>
Date: Tue, 26 Apr 2016 18:44:08 -0400
Subject: [PATCH] Add completion of color functions in CSS mode

* lisp/textmodes/css-mode.el (css-value-class-alist): Add CSS color
  functions as candidates for color values.
---
 lisp/textmodes/css-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index e30fb3e..78d4736 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -463,7 +463,8 @@ further value candidates, since that list would be infinite.")
     (color
      "aqua" "black" "blue" "fuchsia" "gray" "green" "lime" "maroon"
      "navy" "olive" "orange" "purple" "red" "silver" "teal" "white"
-     "yellow" "transparent")
+     "yellow" "transparent" color-functions)
+    (color-functions "color-mod()" "device-cmyk()" "gray()" "hsl()" "hsla()" "hwb()" "rgb()" "rgba()")
     (common-lig-values "common-ligatures" "no-common-ligatures")
     (contextual-alt-values "contextual" "no-contextual")
     (counter "counter()" "counters()")
-- 
2.8.1


                 reply	other threads:[~2016-04-26 22:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426184618.5d8fd906@ThinkPax \
    --to=yuicopr@gmail.com \
    --cc=23384@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).