From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pierre Neidhardt Newsgroups: gmane.emacs.bugs Subject: bug#20663: page.el (forward-page): Avoid skipping pages Date: Sun, 10 Apr 2016 08:29:24 +0700 Message-ID: <20160410012924.GA23097@gmail.com> References: <20150526171440.GG647@gmail.com> <87h9fbum2w.fsf@mbork.pl> <83h9fbhu0p.fsf@gnu.org> <871t6eve9c.fsf@mbork.pl> <837fg6injl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1460251631 22397 80.91.229.3 (10 Apr 2016 01:27:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Apr 2016 01:27:11 +0000 (UTC) Cc: 20663@debbugs.gnu.org, Marcin Borkowski To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 10 03:27:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ap49d-0004dk-7k for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Apr 2016 03:27:09 +0200 Original-Received: from localhost ([::1]:33459 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap49c-0000pV-EF for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 21:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap49Z-0000nW-2f for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 21:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ap49V-00065M-Sb for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 21:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap49V-00065H-PH for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 21:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ap49V-000604-LY for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 21:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Apr 2016 01:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20663-submit@debbugs.gnu.org id=B20663.146025160823045 (code B ref 20663); Sun, 10 Apr 2016 01:27:01 +0000 Original-Received: (at 20663) by debbugs.gnu.org; 10 Apr 2016 01:26:48 +0000 Original-Received: from localhost ([127.0.0.1]:56468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ap49I-0005zd-1M for submit@debbugs.gnu.org; Sat, 09 Apr 2016 21:26:48 -0400 Original-Received: from mail-pa0-f67.google.com ([209.85.220.67]:34825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ap49G-0005zP-C0 for 20663@debbugs.gnu.org; Sat, 09 Apr 2016 21:26:46 -0400 Original-Received: by mail-pa0-f67.google.com with SMTP id zy2so11694735pac.2 for <20663@debbugs.gnu.org>; Sat, 09 Apr 2016 18:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=77+yjqm6il57NsBfuVJ/FbZwTJ2ikSda5VIYp3TVEUQ=; b=aw695Lod5bueBzGpfoHKZFNJJlo+sMKLALLHo6Weqxezk/aW3ZN0ZgEBwhZW0KigjI 94ohw2w8mtHmJyEByJUrGSiTYygvqH8/Ty+B4beC/Zr+9OAnCQUXCA7WQLKGNK6himDh CZ0SkcOZPmx55EZbd+e3d6UWYZmBXt+Q+fHzryb8Wl1HzyjpU3mzcHoyxjhUzpLMUfpy QnqK9AvruS4iV4p5sNNY2cfbyhNpJuZ/lKoPlateZb52GsHsTP31TkHjPfg08G951SMR Ad7kYAAzx8zf4431TeCprVj5tXsilsBagUmHm8OhtFA4uXXvMtaEujp+2QTQvegDZiLP ugfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=77+yjqm6il57NsBfuVJ/FbZwTJ2ikSda5VIYp3TVEUQ=; b=BZRmrOQ3mQgXFjdCuIWFewo/G8fFhtDTp2PCaIbrpeoVW48fz7QTQXPRJG0XC0jSBx aFNhC97zRn7Qqndo1pVTd0nN0kwrKKBslknBsi7Ea746QvQFBV13CZxSsCbbGuRsXCFK YSytVHAEeq6CeyVqrvHMcqFhkY8vtbQxdWEDOS1eB/RtGR4DkhqO6mgH1KYk+DH9Zw9T yQpr9dhnL0S0c71upj1OQNggQHHKYr97n4eOj1SsZLycmhrJY5WDVrAyyZJro7MO4+Su yX5g1LX519ppyzHZhryPc1At7AEkrTsNF5LtCciuVh2c8d+rTgnyabVOYmuWNHiiD7ub sOcQ== X-Gm-Message-State: AD7BkJICsOhp9Qm3EyvM4Bov2JutIn6qBR01xTxZ4TQ2w5JrnqgvcJ0yjS0VM7eUovD26g== X-Received: by 10.66.235.9 with SMTP id ui9mr23091510pac.135.1460251600511; Sat, 09 Apr 2016 18:26:40 -0700 (PDT) Original-Received: from gmail.com ([116.106.2.232]) by smtp.gmail.com with ESMTPSA id s26sm27340672pfa.0.2016.04.09.18.26.38 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 09 Apr 2016 18:26:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <837fg6injl.fsf@gnu.org> X-Info: Simplicity is the ultimate sophistication. User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116296 Archived-At: I did not expect this patch to be so confusing, but let me clarify the above questions: - `forward-page' is called by `narrow-to-page', which is bound to 'C-x n p' by default. - All the patch does it make the code consistent with its comments, that is: ;; In case the page-delimiter matches the null string, ;; don't find a match without moving. - If you try the recipe (I just did on Emacs 24.5.1, don't have time to check now on upstream), you'll see that a page gets skipped, which is not the desired behaviour. - As for side effects, there might be some, althought I haven't noticed anything in a year of use. If there is, then it is a bug in the caller. -- Pierre Neidhardt