From: Pierre Neidhardt <ambrevar@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20663@debbugs.gnu.org, Marcin Borkowski <mbork@mbork.pl>
Subject: bug#20663: page.el (forward-page): Avoid skipping pages
Date: Sun, 10 Apr 2016 08:29:24 +0700 [thread overview]
Message-ID: <20160410012924.GA23097@gmail.com> (raw)
In-Reply-To: <837fg6injl.fsf@gnu.org>
I did not expect this patch to be so confusing, but let me clarify the above questions:
- `forward-page' is called by `narrow-to-page', which is bound to 'C-x n p' by
default.
- All the patch does it make the code consistent with its comments, that is:
;; In case the page-delimiter matches the null string,
;; don't find a match without moving.
- If you try the recipe (I just did on Emacs 24.5.1, don't have time to check
now on upstream), you'll see that a page gets skipped, which is not the desired
behaviour.
- As for side effects, there might be some, althought I haven't noticed anything
in a year of use. If there is, then it is a bug in the caller.
--
Pierre Neidhardt
next prev parent reply other threads:[~2016-04-10 1:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 17:14 bug#20663: page.el (forward-page): Avoid skipping pages Pierre Neidhardt
2016-04-09 10:13 ` Marcin Borkowski
2016-04-09 12:00 ` Eli Zaretskii
2016-04-09 18:16 ` Marcin Borkowski
2016-04-09 19:34 ` Eli Zaretskii
2016-04-10 1:29 ` Pierre Neidhardt [this message]
2016-04-11 10:20 ` Marcin Borkowski
2016-04-11 15:35 ` Eli Zaretskii
2016-04-13 17:53 ` Marcin Borkowski
2016-04-13 20:14 ` John Mastro
2016-04-13 20:54 ` Marcin Borkowski
2016-04-16 11:03 ` Marcin Borkowski
2016-04-16 11:26 ` Eli Zaretskii
2016-04-20 7:32 ` Marcin Borkowski
2016-04-27 7:57 ` Pierre Neidhardt
2016-05-02 20:42 ` Marcin Borkowski
2016-06-04 9:55 ` Pierre Neidhardt
2016-06-04 20:36 ` Marcin Borkowski
2020-09-15 13:53 ` Lars Ingebrigtsen
2022-04-22 12:05 ` Lars Ingebrigtsen
[not found] ` <87pmjje5mt.fsf@kraus.my>
2022-06-09 10:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410012924.GA23097@gmail.com \
--to=ambrevar@gmail.com \
--cc=20663@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mbork@mbork.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).