unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Etienne Prud'homme <e.e.f.prudhomme@gmail.com>
To: 23188@debbugs.gnu.org
Subject: bug#23188: [PATCH] Support completion of at-rules in SCSS mode
Date: Fri, 1 Apr 2016 15:57:07 -0400	[thread overview]
Message-ID: <20160401155707.4730bda5@ThinkPax> (raw)

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

The attached patch adds support for at-rules completion in SCSS mode.
It’s more or less the same code from bug#23135 (Support completion of
bang-rules in CSS mode).

[-- Attachment #2: 0001-Support-completion-of-at-rules-in-SCSS-mode.patch --]
[-- Type: text/x-patch, Size: 1909 bytes --]

From 4ad8f21f11ed9c48f986cfdd8d50883389fa8d2a Mon Sep 17 00:00:00 2001
From: Etienne Prud'homme <e.e.f.prudhomme@gmail.com>
Date: Fri, 1 Apr 2016 15:09:15 -0400
Subject: [PATCH] Support completion of at-rules in SCSS mode

---
 lisp/textmodes/css-mode.el | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el
index cbef3d4..02a5b11 100644
--- a/lisp/textmodes/css-mode.el
+++ b/lisp/textmodes/css-mode.el
@@ -56,6 +56,15 @@
   '("charset" "font-face" "import" "media" "namespace" "page")
   "Identifiers that appear in the form @foo.")
 
+(defconst scss-at-ids
+  '("at-root" "content" "debug" "each" "else" "else if" "error" "extend" "for"
+    "function" "if" "import" "include" "mixin" "return" "warn" "while")
+  "Additional identifiers that appear in the form @foo in SCSS.")
+
+(defvar css--at-ids css-at-ids
+  "List of at-rules for the current mode.")
+(make-variable-buffer-local 'css--at-ids)
+
 (defconst css-bang-ids
   '("important")
   "Identifiers that appear in the form !foo.")
@@ -759,7 +768,7 @@ cannot be completed sensibly: `angle', `element-reference',
     (let ((pos (point)))
       (skip-chars-backward "-[:alnum:]")
       (when (eq (char-before) ?\@)
-        (list (point) pos css-at-ids)))))
+        (list (point) pos css--at-ids)))))
 
 (defvar css--property-value-cache
   (make-hash-table :test 'equal :size (length css-property-alist))
@@ -969,6 +978,7 @@ pseudo-elements, pseudo-classes, at-rules, and bang-rules."
   (setq-local comment-continue " *")
   (setq-local comment-start-skip "/[*/]+[ \t]*")
   (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*+/\\)")
+  (setq-local css--at-ids (append css-at-ids scss-at-ids))
   (setq-local css--bang-ids (append css-bang-ids scss-bang-ids))
   (setq-local font-lock-defaults
               (list (scss-font-lock-keywords) nil t)))
-- 
2.8.0


             reply	other threads:[~2016-04-01 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 19:57 Etienne Prud'homme [this message]
2016-04-03 11:18 ` bug#23188: [PATCH] Support completion of at-rules in SCSS mode Simen Heggestøyl
2016-04-04 19:44   ` Etienne Prud'homme
2016-04-05 21:18     ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401155707.4730bda5@ThinkPax \
    --to=e.e.f.prudhomme@gmail.com \
    --cc=23188@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).