From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#23127: 25.0.92; Assertion failure when editing history in query-replace in cc-mode Date: Tue, 29 Mar 2016 10:03:09 +0000 Message-ID: <20160329100309.GA3377@acm.fritz.box> References: <20160328220210.57301.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1459246217 6233 80.91.229.3 (29 Mar 2016 10:10:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2016 10:10:17 +0000 (UTC) Cc: 23127@debbugs.gnu.org To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 29 12:10:05 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akqb3-0007Mg-NQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 12:10:01 +0200 Original-Received: from localhost ([::1]:45617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqb2-0000zO-6X for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 06:10:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqSS-0001wH-Em for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 06:01:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akqSM-0000Pm-2f for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 06:01:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akqSL-0000Pi-T4 for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 06:01:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akqSL-0006mB-Jx for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 06:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Mar 2016 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23127-submit@debbugs.gnu.org id=B23127.145924561925987 (code B ref 23127); Tue, 29 Mar 2016 10:01:01 +0000 Original-Received: (at 23127) by debbugs.gnu.org; 29 Mar 2016 10:00:19 +0000 Original-Received: from localhost ([127.0.0.1]:42844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akqRe-0006l5-Sx for submit@debbugs.gnu.org; Tue, 29 Mar 2016 06:00:19 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:14239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akqRd-0006kx-L1 for 23127@debbugs.gnu.org; Tue, 29 Mar 2016 06:00:18 -0400 Original-Received: (qmail 60066 invoked by uid 3782); 29 Mar 2016 10:00:16 -0000 Original-Received: from acm.muc.de (p548A5478.dip0.t-ipconnect.de [84.138.84.120]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 29 Mar 2016 12:00:15 +0200 Original-Received: (qmail 3417 invoked by uid 1000); 29 Mar 2016 10:03:09 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115689 Archived-At: Hello, Richard. On Tue, Mar 29, 2016 at 12:24:20AM +0100, Richard Copley wrote: > Thanks very much Alan. > I tested your patch and noticed that it fixes query-replace but not > query-replace-regexp. Whoops! > I won't submit a new patch because I don't have the paperwork (sorry), > but I reckon you just need to move the "(with-current-buffer (...) > (let (...) ...))" construct outside the "(if regexp-flag ...)". With > that change it works fine for me. And it works fine for me, too. Thanks for spotting that. I've committed the fix (to the emacs-25 branch in the savannah repository), and I'm closing the bug. -- Alan Mackenzie (Nuremberg, Germany).