From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#19851: 25.0.50; package-install-{file,from-buffer} broken Date: Sat, 19 Dec 2015 14:21:20 -0500 Message-ID: <20151219192120.GA5491@holos> References: <87lhk2ej84.fsf@udel.edu> <20150213010449.GA5865@holos> <20150309061049.GA10717@holos> <87wpz5zyot.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1450552942 16238 80.91.229.3 (19 Dec 2015 19:22:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Dec 2015 19:22:22 +0000 (UTC) Cc: 19851@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 19 20:22:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aAN51-00048w-Ul for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Dec 2015 20:22:12 +0100 Original-Received: from localhost ([::1]:38363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAN51-0001ug-6h for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Dec 2015 14:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAN4w-0001sV-7r for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2015 14:22:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAN4s-0004KY-Vm for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2015 14:22:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAN4s-0004KS-PF for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2015 14:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aAN4s-00025R-Gb for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2015 14:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Dec 2015 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19851-submit@debbugs.gnu.org id=B19851.14505528897979 (code B ref 19851); Sat, 19 Dec 2015 19:22:02 +0000 Original-Received: (at 19851) by debbugs.gnu.org; 19 Dec 2015 19:21:29 +0000 Original-Received: from localhost ([127.0.0.1]:57211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aAN4L-00024d-7I for submit@debbugs.gnu.org; Sat, 19 Dec 2015 14:21:29 -0500 Original-Received: from mail-qk0-f181.google.com ([209.85.220.181]:33417) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aAN4J-00024Q-TE for 19851@debbugs.gnu.org; Sat, 19 Dec 2015 14:21:28 -0500 Original-Received: by mail-qk0-f181.google.com with SMTP id k189so124120385qkc.0 for <19851@debbugs.gnu.org>; Sat, 19 Dec 2015 11:21:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=SFDh00dZOOu6ajDN3JIR1gNxgRv+Sycv/V8820KdnEA=; b=FMvuDNsh353BuEvfkp33RwXgVcIpeGDdJe+Poe5v9bRVLAPMmtpxvz67r+SlJ1xngr I8VUro7LWAwZhs9ppg9T6xIp0IMwHCVqTvB/DZN3J3njZTdTOMmG8U/xg3+pigPl/H+n Ep8fpeIE0b9uF5xgMp40SWoGGLc1DM7Ks1mUVknJVzMULYuLvYOpQqvrG9nAwmNcW2Ng G+0+6xIPPAUkoQWsLe+T+/lnZ3AeNospXmatc5OQ7MSEjtTT/16DKCxUGEo5aTIDM23f U+yGpZL6IRrdw3VjDEq5+iQsMA1OXBpcp+lFE9NCv/nJVE9GCABUt0vI7fgM/hvWnP63 mXeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=SFDh00dZOOu6ajDN3JIR1gNxgRv+Sycv/V8820KdnEA=; b=Bzzreat7hTWBb1vY24wzmX+9/i8cXPFho8Wv439Ca/NEgKLnEmdbXQZ6wzg7+N9UJV jLh63/wGQCnNUg9RnwTwqQrK4qBknGZF4ujRSyvi9ZrrjXaJYhItkb6uG/HOthcjsxHl +OPbpQ/2fXj7oVU/sg4gLpAn14AKsL/dtSZRivGpszvAvrQylAxQCtIO4uFhpShfRzIg e9xJmWLwdlxJxtJPbT+MNw94F07Lxu/yikSzhbCL1mLtAVbxjTtbYvvnS44oVGVU4mnF mhF1xl5awuEtmdlirdHwtlom7GPw5bQYb3AMCUNY5bVj7DPSnv71AS69kpDJlzecjCaA 6okw== X-Gm-Message-State: ALoCoQn54nex3sBn6Qz0IBPSHmjTfUaCTzfn+0zPQdWw3nJUdl6nHM8wLOVt1TkVK494KMnNQN1HdAtDrsrniXaFF0UPo+skfg== X-Received: by 10.55.198.81 with SMTP id b78mr14058149qkj.102.1450552882463; Sat, 19 Dec 2015 11:21:22 -0800 (PST) Original-Received: from holos.localdomain (pool-96-227-83-242.phlapa.fios.verizon.net. [96.227.83.242]) by smtp.gmail.com with ESMTPSA id c190sm9421624qkb.27.2015.12.19.11.21.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Dec 2015 11:21:21 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 2C4B7696AC; Sat, 19 Dec 2015 14:21:20 -0500 (EST) Content-Disposition: inline In-Reply-To: <87wpz5zyot.fsf@mail.linkov.net> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110187 Archived-At: On 15/06/15 at 11:56pm, Juri Linkov wrote: > > Found it. It is from using package-install-file on a directory while > > saveplace is enabled. Saveplace gets stuck. From emacs -Q: > > > > 1. mkdir /some/new/dir > > 2. Evaluate: > > > > (setq-default save-place t) > > (require 'saveplace) > > (package-initialize) > > > > 3. M-x package-install-file RET /some/new/dir RET > > > > "dired-current-directory: No subdir-alist in *temp*" > > > > In order to quit emacs, one has to hack around kill-emacs-hook. > > Does this patch fix it for you? > > diff --git a/lisp/saveplace.el b/lisp/saveplace.el > index fe54743..5bbcd79 100644 > --- a/lisp/saveplace.el > +++ b/lisp/saveplace.el > @@ -158,6 +158,8 @@ (defun toggle-save-place (&optional parg) ;FIXME: save-place-local-mode! > \(setq-default save-place t)" > (interactive "P") > (if (not (or buffer-file-name (and (derived-mode-p 'dired-mode) > + (boundp 'dired-subdir-alist) > + dired-subdir-alist > (dired-current-directory)))) > (message "Buffer `%s' not visiting a file or directory" (buffer-name)) > (setq save-place (if parg > @@ -178,6 +180,8 @@ (defun save-place-to-alist () > ;; will be saved again when Emacs is killed. > (or save-place-loaded (load-save-place-alist-from-file)) > (let* ((directory (and (derived-mode-p 'dired-mode) > + (boundp 'dired-subdir-alist) > + dired-subdir-alist > (dired-current-directory))) > (item (or buffer-file-name > (and directory > @@ -310,6 +314,8 @@ (defun save-places-to-alist () > ;; save-place checks buffer-file-name too, but we can avoid > ;; overhead of function call by checking here too. > (and (or buffer-file-name (and (derived-mode-p 'dired-mode) > + (boundp 'dired-subdir-alist) > + dired-subdir-alist > (dired-current-directory))) > (save-place-to-alist)) > (setq buf-list (cdr buf-list)))))) > @@ -331,6 +337,8 @@ (defun save-place-dired-hook () > "Position the point in a Dired buffer." > (or save-place-loaded (load-save-place-alist-from-file)) > (let* ((directory (and (derived-mode-p 'dired-mode) > + (boundp 'dired-subdir-alist) > + dired-subdir-alist > (dired-current-directory))) > (cell (assoc (and directory > (expand-file-name (if (consp directory) Could this patch be applied? I have been running with it for so long that getting this bug again reminded me I forgot to apply it this last time.