From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping Date: Thu, 10 Dec 2015 10:18:04 +0100 Message-ID: <20151210091804.GA1785@odonien.bevuta.com> References: <83bna0di5k.fsf@gnu.org> <20151208163208.GA1080@odonien.bevuta.com> <837fkodf3e.fsf@gnu.org> <83zixkbyoj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: ger.gmane.org 1449739161 29644 80.91.229.3 (10 Dec 2015 09:19:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Dec 2015 09:19:21 +0000 (UTC) Cc: John Wiegley , 22114@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 10 10:19:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a6xNW-0005Ez-1N for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Dec 2015 10:19:10 +0100 Original-Received: from localhost ([::1]:40082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xNV-00060V-5E for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Dec 2015 04:19:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xNR-0005zK-Bw for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2015 04:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6xNO-0006vj-29 for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2015 04:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xNN-0006vd-Ue for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2015 04:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1a6xNN-00045q-Ks for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2015 04:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Dec 2015 09:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22114-submit@debbugs.gnu.org id=B22114.144973910215656 (code B ref 22114); Thu, 10 Dec 2015 09:19:01 +0000 Original-Received: (at 22114) by debbugs.gnu.org; 10 Dec 2015 09:18:22 +0000 Original-Received: from localhost ([127.0.0.1]:38594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a6xMj-00044S-Qe for submit@debbugs.gnu.org; Thu, 10 Dec 2015 04:18:21 -0500 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:38762) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a6xMh-000447-VO for 22114@debbugs.gnu.org; Thu, 10 Dec 2015 04:18:20 -0500 Original-Received: by wmec201 with SMTP id c201so15717223wme.1 for <22114@debbugs.gnu.org>; Thu, 10 Dec 2015 01:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=VbYlN9MokhPT6WC6EWBAnjXi7v99fpsUioXzjgszFWk=; b=opRL1CkGgfsLrFSloF3nKjlsaoL9JgfnTiSz4eJfProEP3siiLHhMuEDoQ/8A8Ej4F tfcRR3quDVOekUen/kQU6sXz8n38Id/AvB6l0HVOV1tSq/45Q/KGnKpZ/lcREPHwhIp/ dmT0LHGfzKeogcOmxAl17MDYpaKL01NKWxGkSkYKeYr/JgZANF99tUqMu8/7nnreWJQb ULOnSM6KwjVYM6bBDOX7QmU01alIXD9HJhYnpbITqP/BaMLwIpodUdKBTjcgP2DQmoNe HSuJ9VPvQKEW447WdDNwZbJi1gNl/IOAvbWY2QzRM30Q/YtbbeK/0Cz9XEYHDVykmxGB n4WA== X-Received: by 10.194.250.39 with SMTP id yz7mr12577515wjc.92.1449739094424; Thu, 10 Dec 2015 01:18:14 -0800 (PST) Original-Received: from localhost ([89.15.236.120]) by smtp.gmail.com with ESMTPSA id u205sm11851243wmb.12.2015.12.10.01.18.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Dec 2015 01:18:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <83zixkbyoj.fsf@gnu.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109830 Archived-At: > This is a completely different issue, and AFAIU the proposed patch > didn't allow that. The C-level implementation of producing a profiler > log (which is then used to format a report) resets the profile data > once it returns the log, and then starts collecting the profile data > anew. The OP's patch didn't change that. How feasible would it be to make the log a regular hash table, fill it with vectors of the right size and then manipulate these vectors every time a profiling signal is received? Or alternatively, fiddle with the hash table values? A successful patch doing that would remove the need for being clever about storing logs/reports, resetting logs and on top of that allow you to view in-progress reports like John Wiegley suggested.