From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vasilij Schneidermann <v.schneidermann@gmail.com> Newsgroups: gmane.emacs.bugs Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping Date: Tue, 8 Dec 2015 19:12:37 +0100 Message-ID: <20151208181237.GA19310@odonien.bevuta.com> References: <CAPGgwWRsmiD_H98FkEPUFyWuyeWO1rD0OG3HhXN9u54CP2Ad8g@mail.gmail.com> <83bna0di5k.fsf@gnu.org> <20151208163208.GA1080@odonien.bevuta.com> <837fkodf3e.fsf@gnu.org> <m2twns4z1u.fsf@newartisans.com> <20151208175654.GD1080@odonien.bevuta.com> <m2d1ug4y52.fsf@newartisans.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: ger.gmane.org 1449598409 13935 80.91.229.3 (8 Dec 2015 18:13:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Dec 2015 18:13:29 +0000 (UTC) Cc: 22114@debbugs.gnu.org To: John Wiegley <jwiegley@gmail.com> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 08 19:13:17 2015 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>) id 1a6MlF-0002FB-HN for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Dec 2015 19:13:13 +0100 Original-Received: from localhost ([::1]:32915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>) id 1a6MlE-0001VB-Qi for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Dec 2015 13:13:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a6Ml9-0001V4-OU for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:13:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a6Ml4-00066d-PI for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:13:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a6Ml4-00066Y-Mc for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1a6Ml4-0001IS-GP for bug-gnu-emacs@gnu.org; Tue, 08 Dec 2015 13:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann <v.schneidermann@gmail.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Dec 2015 18:13:02 +0000 Resent-Message-ID: <handler.22114.B22114.14495983614930@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22114-submit@debbugs.gnu.org id=B22114.14495983614930 (code B ref 22114); Tue, 08 Dec 2015 18:13:02 +0000 Original-Received: (at 22114) by debbugs.gnu.org; 8 Dec 2015 18:12:41 +0000 Original-Received: from localhost ([127.0.0.1]:43510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1a6Mki-0001HS-Rn for submit@debbugs.gnu.org; Tue, 08 Dec 2015 13:12:41 -0500 Original-Received: from mail-wm0-f50.google.com ([74.125.82.50]:34738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <v.schneidermann@gmail.com>) id 1a6Mkh-0001HI-52 for 22114@debbugs.gnu.org; Tue, 08 Dec 2015 13:12:39 -0500 Original-Received: by wmvv187 with SMTP id v187so225693262wmv.1 for <22114@debbugs.gnu.org>; Tue, 08 Dec 2015 10:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=si0WqwApG/q0NqOWEnunAibJF2kTjR3UBs2K6B7CnHo=; b=vMP1uqh2QAHGmwvAb/qoXOnvn9xn41RvQirhCeSqEit/0u3wL6giG0Lj9A2mD9Gjeo 9Zhc+h902wcFwVNb/yK/DGx/oxQn62sS1oa/9KK+BO5J2yKTuA19rTNBJx5k3yRW6Ey7 dll9eZMYfBn/ibt5BhLRZwl7FdUKsHClNNEwdKVqDw/ux3Iq4EuwwO3c9861PBGSJM7T t9acsOiU2zy9zbrlnpLz/G585WXgMLPoKi2CSp1UK1cMb+sCf9mDhSsqFk8BZVRD6b+s 5nxQiJ48XEkflaf4PRuX0T/vw5PKuMvJKpZ29Bt7hwAEj1w9jIFTq4eU6Sn+GpN5E3xA vElA== X-Received: by 10.28.153.137 with SMTP id b131mr6412711wme.3.1449598358645; Tue, 08 Dec 2015 10:12:38 -0800 (PST) Original-Received: from localhost (port-92-204-65-240.dynamic.qsc.de. [92.204.65.240]) by smtp.gmail.com with ESMTPSA id lx4sm4060168wjb.5.2015.12.08.10.12.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Dec 2015 10:12:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <m2d1ug4y52.fsf@newartisans.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109782 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/109782> > You just want the profiler report display to be idempotent? Wouldn't this mean > necessitating another command call in order to reset results? Some people may > be used to the fact that a report resets the results. That's correct. I consider an implementation using a variable more resilient than relying on the user not to kill the buffer (which isn't as unlikely as you'd think, given newbie questions of how to make Emacs open less buffers). Resetting does already have a command, `profiler-reset`. I've adjusted it in my patch to set the variables to `nil` so that it will behave correctly in accordance with the other changes.