From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Werner LEMBERG Newsgroups: gmane.emacs.bugs Subject: bug#20628: 25.0.50; Incorrect line height for some fonts Date: Wed, 03 Jun 2015 11:44:17 +0200 (CEST) Message-ID: <20150603.114417.268457608.wl@gnu.org> References: <20150524.113203.250674550.wl@gnu.org> <83617i1f29.fsf@gnu.org> <834mn21e7y.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1433324735 16636 80.91.229.3 (3 Jun 2015 09:45:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Jun 2015 09:45:35 +0000 (UTC) Cc: clement.pitclaudel@live.com, ohwoeowho@gmail.com, 20628@debbugs.gnu.org To: eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 03 11:45:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z05EZ-0005tX-JZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jun 2015 11:45:15 +0200 Original-Received: from localhost ([::1]:34308 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z05EY-0004Wd-Ox for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jun 2015 05:45:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z05ET-0004SB-KZ for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 05:45:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z05EO-0007hd-GE for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 05:45:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z05EO-0007gS-5Q for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 05:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z05EN-0002VN-J6 for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 05:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Werner LEMBERG Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jun 2015 09:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20628-submit@debbugs.gnu.org id=B20628.14333246699560 (code B ref 20628); Wed, 03 Jun 2015 09:45:03 +0000 Original-Received: (at 20628) by debbugs.gnu.org; 3 Jun 2015 09:44:29 +0000 Original-Received: from localhost ([127.0.0.1]:38256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z05Do-0002U7-2i for submit@debbugs.gnu.org; Wed, 03 Jun 2015 05:44:28 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:61382) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z05Dl-0002Tp-8L for 20628@debbugs.gnu.org; Wed, 03 Jun 2015 05:44:25 -0400 Original-Received: from gnu.org ([91.115.88.13]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MHoC5-1Yx2x53TJN-003hMI; Wed, 03 Jun 2015 11:44:19 +0200 In-Reply-To: <834mn21e7y.fsf@gnu.org> X-Mailer: Mew version 6.5 on Emacs 25.0.50.1 / Mule 6.0 (HANACHIRUSATO) X-Provags-ID: V03:K0:AX3WT1mk2SbloR5YBD0/NsO1PGyPVLVplh2fMJ7aQ1yLwG3TcQH jRUKRnmZYDbOHPFfq4SsjzLiZAQTT/5julGIkgZSe+04xjmuelq0Cb6pAp586cOUVXbuxRq XFMKnz9hpreUUte4Gl5T0vKv/keWq8CTmCc0Iw7uy1vu2NffBX0HIAGDoog5zQf9YNqV9C2 LKVfOpJLEDZuX7JLl822Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:SlwxssEOoT0=:kKRrte8qz/0yATTT2JfYfe gyMHW+vZr14QUH4Q8z185IQBbTwSzLvA0SRTdKSFgDskAVO8TedsFEHKyonuJZvAIYEkBnRU8 BzoS1CzaUjNyuxrJPAZTY77JZ3Y1YPfYHa5e0rYy2mT83zpaSZpbq0UQ2UrBj6eIkcngeHL5b EV9Uzp4T97tkdGaHVmkp2BrjqJHVsQBWtilb0w44IVArx1xCMlJe+4L5w/SZuMi00nvrjkvBt 9zPy5/Yk64I3VceswM3CHrmvDwlucSuqC0l9WhMr8nsloEHrUJ19Fwrnugc5421iQEq77ssLo IeodOYOJAC4uvbBA5s7pQUo5saqp5IJZBk4nYLTMfbe6AnaZLwwlt1sBHHQZuHqBkxNMC1c9i Zt7raGVgI3sXPowLhezNXMLswz2NEnfzGPcUwiJTCBMJA4RozIMLCxPI+nh7r3POPDXJ9uXij AL5eWGsWrn7oyx/wP70k8FsK+bTdmKThLxUtu20lnDITnnzWSVTINOzXrgLtv2sYFv5+ZRomJ ecHknW5O1U7lvyYhWj6Co6GakhScHnqoKdRjRQM6qFE203Zdqc6v736QKz/YAWIDX2MbmPGXv 4gk8dgn2fMy7A28yRY0lSa3hxZDK2k8dR4mf6HM14jNkwhxQRfg8NO6r24m7LuwUYZFNxgjP1 tvUjOg7f6arSn5qil+pDrt6PTKUute5ZhB3xnsadglON2zLZMQXHPIUKHsI79AW6yHO8= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103534 Archived-At: > The relevant place in the display engine where these factors are > taken into consideration is around line 26388 in xdisp.c, [...] I'm completely lost in this huuuge file. > The change we look for should: > > . set the initial values for it->ascent and it->descent using some > heuristics based on pixel_size of the default face's font; Where are the initial values set? > . update it->ascent and it->descent based on ascent/descent values > returned by get_per_char_metric in the per-character metrics > data I think this already happens, right? At least the line height increases on my GNU/Linux version of Emacs if I use a font with larger ascent/descent values... So no additional action is needed for this, it seems. Werner