From: Pierre Lorenzon <devel@pollock-nageoire.net>
To: monnier@iro.umontreal.ca
Cc: zappo@gnu.org, 20491@debbugs.gnu.org
Subject: bug#20491: 25.0.50; new eieio-oref implementation
Date: Wed, 06 May 2015 09:19:24 +0200 (CEST) [thread overview]
Message-ID: <20150506.091924.180938176964681891.devel@pollock-nageoire.net> (raw)
In-Reply-To: <jwv61895dci.fsf-monnier+emacsbugs@gnu.org>
Hi,
From: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: bug#20491: 25.0.50; new eieio-oref implementation
Date: Sun, 03 May 2015 21:44:33 -0400
>> error("eieio-oref called on a class!")
>> eieio-oref(srecode-template-inserter-section-end key)
>> srecode-compile-inserter("INDENT" "\n"
>
> Does the patch below fix this problem?
>
> AFAICT, the use of `oref' with a class object was never documented as
> a supported feature of EIEIO. You're supposed to use oref-default for that.
>
>
> Stefan
>
>
> diff --git a/lisp/cedet/srecode/compile.el b/lisp/cedet/srecode/compile.el
> index c93a6f7..763c462 100644
> --- a/lisp/cedet/srecode/compile.el
> +++ b/lisp/cedet/srecode/compile.el
> @@ -523,7 +523,7 @@ to the inserter constructor."
> (setq classes (append classes (eieio-class-children (car classes))))
> ;; Do we have a match?
> (when (and (not (class-abstract-p (car classes)))
> - (equal (oref (car classes) key) key))
> + (equal (oref-default (car classes) key) key))
> ;; Create the new class, and apply state.
> (setq new (apply (car classes) name props))
> (srecode-inserter-apply-state new STATE)
In fact it corrects the problem but maybe I did not
tell you and that's why you did not install this
change in the git repo. I cloned it today.
Pierre
next prev parent reply other threads:[~2015-05-06 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 5:29 bug#20491: 25.0.50; new eieio-oref implementation Pierre Lorenzon
2015-05-04 1:44 ` Stefan Monnier
2015-05-06 7:19 ` Pierre Lorenzon [this message]
2015-05-06 13:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506.091924.180938176964681891.devel@pollock-nageoire.net \
--to=devel@pollock-nageoire.net \
--cc=20491@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=zappo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).