From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 20074@debbugs.gnu.org, Mario Valencia <mariovalspi@gmail.com>
Subject: bug#20074: edebug tracing can't be stopped with 'S'
Date: Mon, 16 Mar 2015 11:38:35 +0000 [thread overview]
Message-ID: <20150316113835.GA3286@acm.fritz.box> (raw)
In-Reply-To: <jwvd249tz3m.fsf-monnier+emacsbugs@gnu.org>
Hello, Stefan.
On Sun, Mar 15, 2015 at 11:12:52PM -0400, Stefan Monnier wrote:
> > - (sit-for edebug-sit-for-seconds)) ; Force update and pause.
> > + (if (not (sit-for edebug-sit-for-seconds))
> > + (setq edebug-stop t))) ; Force update and pause.
> Looks much better, thanks. I wonder if the other sit-for call should do
> the same.
You mean for the one for when `edebug-execution-mode' is 'Trace-fast. I
don't think that's the right solution. If we did that, some "S"s from
Trace-fast would get caught by the "(if (input-pending)...)" at L+91,
and the others will get caught by the "(sit-for 0)".
Perhaps a better solution might be to move the "(if (input-pending) ...)"
to just after these two "(sit-for ..)"s, and just before the call to
edebug--recursive-edit. Then all the testing for input events will be
done in the one place. What that `if' form does doesn't seem critical to
the functionality, apart from setting `edebug-stop' to t -
"(edebug-stop)" merely displays "STOP" in the echo area.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2015-03-16 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 20:42 bug#20074: edebug tracing can't be stopped with 'S' Mario Valencia
2015-03-11 16:24 ` Eli Zaretskii
[not found] ` <CA+3HrJXsgWHQG_6zk2vNXzEaqT8w-5-cw26fkLYH0xQXmk=nSQ@mail.gmail.com>
2015-03-11 16:28 ` bug#20074: Fwd: " Mario Valencia
2015-03-11 16:30 ` Mario Valencia
2015-03-13 9:36 ` Mario Valencia
2015-03-13 10:19 ` Alexis
2015-03-13 11:07 ` Eli Zaretskii
2015-03-13 11:37 ` Alexis
2015-03-13 13:20 ` Stefan Monnier
2015-03-13 14:02 ` Alexis
2015-03-14 18:49 ` Mario Valencia
[not found] ` <mailman.2024.1426359010.31049.bug-gnu-emacs@gnu.org>
2015-03-15 16:06 ` Alan Mackenzie
2015-03-15 20:36 ` Stefan Monnier
2015-03-15 21:31 ` Alan Mackenzie
[not found] ` <mailman.2056.1426435627.31049.bug-gnu-emacs@gnu.org>
2015-03-15 19:55 ` Alan Mackenzie
2015-03-16 3:12 ` Stefan Monnier
2015-03-16 11:38 ` Alan Mackenzie [this message]
2015-03-16 13:11 ` Stefan Monnier
[not found] ` <mailman.1823.1426020966.31049.bug-gnu-emacs@gnu.org>
2015-03-16 22:21 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316113835.GA3286@acm.fritz.box \
--to=acm@muc.de \
--cc=20074@debbugs.gnu.org \
--cc=mariovalspi@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).