From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 20074@debbugs.gnu.org, Mario Valencia <mariovalspi@gmail.com>
Subject: bug#20074: edebug tracing can't be stopped with 'S'
Date: Sun, 15 Mar 2015 21:31:40 +0000 [thread overview]
Message-ID: <20150315213140.GA2970@acm.fritz.box> (raw)
In-Reply-To: <jwv61a2nhl7.fsf-monnier+emacsbugs@gnu.org>
Hello, Stefan.
On Sun, Mar 15, 2015 at 04:36:18PM -0400, Stefan Monnier wrote:
> > What is happening is that while tracing, edebug is waiting for an input
> > event with "(sit-for 1)". When you type the "S", sit-for pushes it onto
> > `unread-command-events' and returns. Unfortunately, before calling the
> > recursive edit into the edebug command loop, `unread-command-events' gets
> > bound to nil, thus edebug doesn't see the "S". The motivation here is
> > probably to separate the "outside" event queue from edebug's event queue.
> Hmmm sounds like we indeed have a problem here.
> > Here is a fix (which Eli will probably call a workaround ;-). In trace
> > mode, the top event (if any) is pulled off the "outside"
> > `unread-command-events' and pushed onto edebug's binding of it.
> I don't quite understand your fix.
Unfortunately, neither did I. It was garbage. Sorry for the time
wasted. I've superseded it with a fix which actually is a fix, I hope.
> AFAICT, the sit-for is inside the let-binding, so when we enter the
> sit-for, unread-command-events is nil (more or less for sure) because we
> just bound it to nil, and when we exit sit-for maybe
> unread-command-events is non-nil, but when we then exit the let-binding
> we throw away whether was added to unread-command-events.
Exactly. That was the bug.
> So I don't understand how changing the entrance to the let-binding fixes
> this problem, since it seems that the info gets lost when we exit the
> let-binding, rather than it being hidden by the let-binding when we
> enter it.
> What am I missing?
My next post to this bug. ;-)
> Also, I wonder why the edebug.el code doesn't use the return value of
> `sit-for'.
It does now.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2015-03-15 21:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 20:42 bug#20074: edebug tracing can't be stopped with 'S' Mario Valencia
2015-03-11 16:24 ` Eli Zaretskii
[not found] ` <CA+3HrJXsgWHQG_6zk2vNXzEaqT8w-5-cw26fkLYH0xQXmk=nSQ@mail.gmail.com>
2015-03-11 16:28 ` bug#20074: Fwd: " Mario Valencia
2015-03-11 16:30 ` Mario Valencia
2015-03-13 9:36 ` Mario Valencia
2015-03-13 10:19 ` Alexis
2015-03-13 11:07 ` Eli Zaretskii
2015-03-13 11:37 ` Alexis
2015-03-13 13:20 ` Stefan Monnier
2015-03-13 14:02 ` Alexis
2015-03-14 18:49 ` Mario Valencia
[not found] ` <mailman.2024.1426359010.31049.bug-gnu-emacs@gnu.org>
2015-03-15 16:06 ` Alan Mackenzie
2015-03-15 20:36 ` Stefan Monnier
2015-03-15 21:31 ` Alan Mackenzie [this message]
[not found] ` <mailman.2056.1426435627.31049.bug-gnu-emacs@gnu.org>
2015-03-15 19:55 ` Alan Mackenzie
2015-03-16 3:12 ` Stefan Monnier
2015-03-16 11:38 ` Alan Mackenzie
2015-03-16 13:11 ` Stefan Monnier
[not found] ` <mailman.1823.1426020966.31049.bug-gnu-emacs@gnu.org>
2015-03-16 22:21 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150315213140.GA2970@acm.fritz.box \
--to=acm@muc.de \
--cc=20074@debbugs.gnu.org \
--cc=mariovalspi@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).