From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jorgen Schaefer Newsgroups: gmane.emacs.bugs Subject: bug#19296: [PATCH] Package archives now have priorities. Date: Sun, 7 Dec 2014 21:00:38 +0100 Message-ID: <20141207210038.384c7e84@forcix> References: <20141207132244.A14A7200D1E@loki.jorgenschaefer.de> <20141207192105.48c4c41b@forcix> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1417982483 2170 80.91.229.3 (7 Dec 2014 20:01:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Dec 2014 20:01:23 +0000 (UTC) Cc: 19296@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 07 21:01:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xxi16-0001jY-DV for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Dec 2014 21:01:16 +0100 Original-Received: from localhost ([::1]:59025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxi15-0008RZ-U1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Dec 2014 15:01:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxi0y-0008RQ-25 for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 15:01:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xxi0s-0003Dn-M3 for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 15:01:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxi0s-0003Dj-Ih for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 15:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xxi0s-0003rH-62 for bug-gnu-emacs@gnu.org; Sun, 07 Dec 2014 15:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jorgen Schaefer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Dec 2014 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19296-submit@debbugs.gnu.org id=B19296.141798244513650 (code B ref 19296); Sun, 07 Dec 2014 20:01:02 +0000 Original-Received: (at 19296) by debbugs.gnu.org; 7 Dec 2014 20:00:45 +0000 Original-Received: from localhost ([127.0.0.1]:56580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxi0b-0003XT-60 for submit@debbugs.gnu.org; Sun, 07 Dec 2014 15:00:45 -0500 Original-Received: from loki.jorgenschaefer.de ([87.230.15.51]:49811) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxi0X-0003RZ-37 for 19296@debbugs.gnu.org; Sun, 07 Dec 2014 15:00:42 -0500 Original-Received: by loki.jorgenschaefer.de (Postfix, from userid 998) id CE5EE200D2F; Sun, 7 Dec 2014 21:00:39 +0100 (CET) Original-Received: from forcix (port-21631.pppoe.wtnet.de [46.59.146.42]) by loki.jorgenschaefer.de (Postfix) with ESMTPSA id 406CB200D2D; Sun, 7 Dec 2014 21:00:39 +0100 (CET) In-Reply-To: <20141207192105.48c4c41b@forcix> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; i586-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96961 Archived-At: On Sun, 7 Dec 2014 19:21:05 +0100 Jorgen Schaefer wrote: > On Sun, 07 Dec 2014 12:56:53 -0500 > Stefan Monnier wrote: > > > > This can be overridden manually by the user. > > > > An important issue is what happens after the user did such an > > override. In my above suggestion, the behavior would kind of suck > > since package-list would then constantly recommend "upgrading" to > > the official release (since 1.3 is "more uptodate" than > > "0.0.YYYYMMDD"). > > Good point. The correct implementation here would likely move the > sorting by version number out of the > `package--add-to-archive-contents' function and into the various > users of `package-archive-contents', which should sort the list > depending on their use case. This is a breaking API change and likely > a good deal more work. Actually, it should not suggest an upgrade in this case, because the currently installed version is higher than the highest available one (package-menu--find-upgrades). Currently, that method ignores priorities, though, as it uses an entirely different way of looking up the available packages. I'll provide a fixed patch. Regards, Jorgen