unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: 19217@debbugs.gnu.org
Subject: bug#19217: 25.0.50; `C-M-x' (`eval-defun') on a `defface' that is not top-level
Date: 29 Nov 2014 19:10:23 -0000	[thread overview]
Message-ID: <20141129191023.34112.qmail@mail.muc.de> (raw)
In-Reply-To: <mailman.14952.1417284925.1147.bug-gnu-emacs@gnu.org>

Hi, Drew.

In article <mailman.14952.1417284925.1147.bug-gnu-emacs@gnu.org> you wrote:
> Enhancement request.  This has probably been requested before, but
> here goes...

> It is not uncommon to have a `defface' inside a condition such as (when
> (> emacs-major-version 23)...).  Currently, `C-M-x' has no effect on
> such a `defface' occurrence.  In order to have Emacs DTRT, I find myself
> working around this limitation by temporarily moving the `defface' to
> bol.

You can also move point to just after the closing ) and do C-x C-e
(`eval-last-sexp').

> How about letting users redefine a `defface' with `C-M-x' even in this
> case?

How is Emacs to determine which depth of parenthesis is to be considered
the opening one?  For example, if a defface is contained within a
defmacro, which one is to be executed on C-M-x?

> At least optionally.  For example, let a non-positive prefix arg do
> this, and have edebug instrumentation done only for a non-negative
> prefix arg.

> Or maybe always (not optionally)?  Is there a good reason for doing this
> only at top-level?

I think it is to make it unambiguous, which form is to be evaluated.

> If the reason is that `eval-defun' cannot recognize the defun
> (`defface') unless it is at top level, then surely there is some way to
> make this more flexible.

> In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
> of 2014-10-20 on LEG570
> Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
> `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'

-- 
Alan Mackenzie (Nuremberg, Germany).






  parent reply	other threads:[~2014-11-29 19:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29 18:13 bug#19217: 25.0.50; `C-M-x' (`eval-defun') on a `defface' that is not top-level Drew Adams
     [not found] ` <mailman.14952.1417284925.1147.bug-gnu-emacs@gnu.org>
2014-11-29 19:10   ` Alan Mackenzie [this message]
2014-12-01  3:51 ` Stefan Monnier
2014-12-01  4:29   ` Drew Adams
2014-12-01 13:49     ` Stefan Monnier
     [not found] ` <mailman.15037.1417408221.1147.bug-gnu-emacs@gnu.org>
2014-12-01 17:02   ` Alan Mackenzie
     [not found] <<mailman.14952.1417284925.1147.bug-gnu-emacs@gnu.org>
     [not found] ` <<20141129191023.34112.qmail@mail.muc.de>
2014-11-29 20:08   ` Drew Adams
2014-11-30 19:58     ` Alan Mackenzie
2014-11-30 20:51       ` Drew Adams
2014-11-30 23:20         ` Alan Mackenzie
2014-12-01  0:00           ` Drew Adams
2014-12-06 19:10         ` Alan Mackenzie
2014-12-10 22:20           ` Drew Adams
2014-12-13  3:07             ` Drew Adams
2020-09-18 13:36           ` Lars Ingebrigtsen
2020-09-18 15:53             ` Drew Adams
2020-09-19 14:10               ` Lars Ingebrigtsen
2020-10-15 14:28             ` Lars Ingebrigtsen
2020-10-15 15:29               ` Drew Adams
2020-10-15 15:35                 ` Lars Ingebrigtsen
2020-10-15 16:15                   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141129191023.34112.qmail@mail.muc.de \
    --to=acm@muc.de \
    --cc=19217@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).