From: David Logie <djl@acme.pm>
To: 17534@debbugs.gnu.org
Subject: bug#17534: AppleAntiAliasingThreshold default doesn't seem to work
Date: Mon, 7 Jul 2014 16:17:42 +0100 [thread overview]
Message-ID: <20140707153416.1eefa589c4@7ac8e35ad8ee6e6> (raw)
In-Reply-To: <1400598479.44817.YahooMailNeo@web163403.mail.gq1.yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
This bug seems to have been introduced in r114295. A build from r114294
does not have the issue while a build from r114296 does.
Looking at the Mac port, I *think* a call to
`macfont_update_antialias_threshold()` has been missed somewhere.
I managed to cobble together a patch that works for me (see attached)
but I'm sure a more correct solution exists.
[-- Attachment #2: 17534-antialias.patch --]
[-- Type: text/plain, Size: 1177 bytes --]
diff --git a/src/macfont.h b/src/macfont.h
index 8b45135..7421cd6 100644
--- a/src/macfont.h
+++ b/src/macfont.h
@@ -144,4 +144,5 @@ typedef const struct _EmacsScreenFont *ScreenFontRef; /* opaque */
extern void mac_register_font_driver (struct frame *f);
extern void *macfont_get_nsctfont (struct font *font);
+extern void macfont_update_antialias_threshold (void);
diff --git a/src/macfont.m b/src/macfont.m
index 82ee54c..024847b 100644
--- a/src/macfont.m
+++ b/src/macfont.m
@@ -728,7 +728,7 @@ static const struct
static CGFloat macfont_antialias_threshold;
-static void
+void
macfont_update_antialias_threshold (void)
{
int threshold;
diff --git a/src/nsterm.m b/src/nsterm.m
index f2eeeda..753afe9 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -4277,6 +4277,12 @@ ns_term_init (Lisp_Object display_name)
ns_default ("AppleAntiAliasingThreshold", &tmp,
make_float (10.0), make_float (6.0), YES, NO);
ns_antialias_threshold = NILP (tmp) ? 10.0 : XFLOATINT (tmp);
+
+#ifdef NS_IMPL_COCOA
+#if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_5
+ macfont_update_antialias_threshold();
+#endif
+#endif
}
{
next prev parent reply other threads:[~2014-07-07 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 15:07 bug#17534: 24.3.91; AppleAntiAliasingThreshold default doesn't seem to work Mmm Mmmmm
2014-07-07 15:17 ` David Logie [this message]
2014-07-20 13:19 ` bug#17534: " Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707153416.1eefa589c4@7ac8e35ad8ee6e6 \
--to=djl@acme.pm \
--cc=17534@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).