From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#16526: 24.3.50; scroll-conservatively & c-mode regression Date: Sat, 5 Jul 2014 20:25:34 +0000 Message-ID: <20140705202534.GA3449@acm.acm> References: <53B02042.1050107@gmx.at> <20140629144151.GD2948@acm.acm> <53B03876.9070307@gmx.at> <20140629174953.GE2948@acm.acm> <53B117D6.1050306@gmx.at> <20140702200522.GB3823@acm.acm> <20140704182709.GA3535@acm.acm> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1404592305 10785 80.91.229.3 (5 Jul 2014 20:31:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Jul 2014 20:31:45 +0000 (UTC) Cc: 16526@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 05 22:31:37 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X3WcR-0003tA-Jx for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jul 2014 22:31:35 +0200 Original-Received: from localhost ([::1]:43935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3WcQ-0007iC-U0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jul 2014 16:31:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3WcG-0007hx-Ra for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 16:31:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3Wc7-0003pV-GZ for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 16:31:24 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3Wbu-0003oX-AK; Sat, 05 Jul 2014 16:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3Wbt-0008SU-V6; Sat, 05 Jul 2014 16:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sat, 05 Jul 2014 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16526 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 16526-submit@debbugs.gnu.org id=B16526.140459221932461 (code B ref 16526); Sat, 05 Jul 2014 20:31:01 +0000 Original-Received: (at 16526) by debbugs.gnu.org; 5 Jul 2014 20:30:19 +0000 Original-Received: from localhost ([127.0.0.1]:44360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3WbD-0008RT-C5 for submit@debbugs.gnu.org; Sat, 05 Jul 2014 16:30:19 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:50843 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3WbA-0008RG-PS for 16526@debbugs.gnu.org; Sat, 05 Jul 2014 16:30:18 -0400 Original-Received: (qmail 3816 invoked by uid 3782); 5 Jul 2014 20:30:14 -0000 Original-Received: from acm.muc.de (pD951894A.dip0.t-ipconnect.de [217.81.137.74]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 05 Jul 2014 22:30:13 +0200 Original-Received: (qmail 3817 invoked by uid 1000); 5 Jul 2014 20:25:34 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91222 Archived-At: Hi, Stefan. On Fri, Jul 04, 2014 at 03:43:02PM -0400, Stefan Monnier wrote: > > I'm not sure what I'm meant to see, but it has made no perceptible > > difference to the "slow" invocation of scan-lists. In particular, that > > invocation took 0.7196781635284424 seconds with the patch, which is > > "exactly" (near enough) what it took before. > OK, the initialization needs to be after the "lossage:" label, > of course. Try the patch below instead, This works considerably better. :-) The critical scan-lists took 0.12084102630615234 seconds, a speedup of a factor of ~7. It may be even larger than that because of the instrumentation in the patch. CC Mode has a problem in that it does too many backward scan-lists. There is no documentation anywhere of what open-paren-in-column-0-etc does; its sole effect is in backwards scan-lists which encounter "syntactically unbalanced" comments, this causing a scan of the buffer from point-min. When I optimised c-parse-state a few years back, I was under the impression that a backwards scan-lists wasn't much more expensive than a forwards one. Often, this is not true. I should think about adjusting c-parse-state again. It surely wouldn't hurt for the documentation of open-paren-etc and scan-lists to be a bit more forthcoming about backwards scan-listses and what the variable _really_ does. > Stefan -- Alan Mackenzie (Nuremberg, Germany).