* bug#17650: problem with emacs bzr change 117190
[not found] <20140605130231.528718.FMU1898@unexploded-cow.prv.splode.com>
@ 2014-06-06 2:22 ` Stefan Monnier
2014-06-09 19:20 ` Noah Friedman
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2014-06-06 2:22 UTC (permalink / raw)
To: Noah Friedman; +Cc: 17650-done
>>>>> "Noah" == Noah Friedman <noah@splode.com> writes:
> Sorry to keep bugging you about this. I think I know where the problem is
> now.
> In keyboard.c:read_char around line 2847:
> /* If this has become non-nil here, it has been set by a timer
> or sentinel or filter. */
> if (CONSP (Vunread_command_events))
> {
> c = XCAR (Vunread_command_events);
> Vunread_command_events = XCDR (Vunread_command_events);
> }
> This second time that unread-command-events is examined, it's not checking
> for the case that c is a cons.
A `cons' is perfectly normal, but indeed it needs to check if it's
a `cons' whose `car' is t, thanks. The patch below seems to fix
Thierry's case, so hopefully it fixes yours too.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#17650: problem with emacs bzr change 117190
2014-06-06 2:22 ` bug#17650: problem with emacs bzr change 117190 Stefan Monnier
@ 2014-06-09 19:20 ` Noah Friedman
0 siblings, 0 replies; 3+ messages in thread
From: Noah Friedman @ 2014-06-09 19:20 UTC (permalink / raw)
To: monnier; +Cc: 17650-done
Indeed it does. Thanks!
In <jwv4mzyygxq.fsf-monnier+emacsbugs@gnu.org>, Stefan Monnier writes:
>>>>>> "Noah" == Noah Friedman <noah@splode.com> writes:
>
>> Sorry to keep bugging you about this. I think I know where the problem is
>> now.
>
>> In keyboard.c:read_char around line 2847:
>
>> /* If this has become non-nil here, it has been set by a timer
>> or sentinel or filter. */
>> if (CONSP (Vunread_command_events))
>> {
>> c = XCAR (Vunread_command_events);
>> Vunread_command_events = XCDR (Vunread_command_events);
>> }
>
>> This second time that unread-command-events is examined, it's not checking
>> for the case that c is a cons.
>
>A `cons' is perfectly normal, but indeed it needs to check if it's
>a `cons' whose `car' is t, thanks. The patch below seems to fix
>Thierry's case, so hopefully it fixes yours too.
>
>
> Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20140605104329.478653.FMU1898@unexploded-cow.prv.splode.com>]
* bug#17650: problem with emacs bzr change 117190
[not found] <20140605104329.478653.FMU1898@unexploded-cow.prv.splode.com>
@ 2014-06-05 20:56 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2014-06-05 20:56 UTC (permalink / raw)
To: Noah Friedman; +Cc: 17650
> * lisp/subr.el (sit-for): Remove universal-arg dependency.
> Stefan,
> This change is breaking at least one of my programs (flash-paren.el) such
> that whenever it is in a sit-for and I press a key, I get the error
> <t> is not defined
> in the echo area. It seems like something bogus being pushed onto
> unread-command-events although I haven't narrowed it down yet; it's
> difficult to debug functions run via idle timers.
This might be related to bug#17650 (which I haven't really investigated
yet). Can you provide a recipe?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-09 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140605130231.528718.FMU1898@unexploded-cow.prv.splode.com>
2014-06-06 2:22 ` bug#17650: problem with emacs bzr change 117190 Stefan Monnier
2014-06-09 19:20 ` Noah Friedman
[not found] <20140605104329.478653.FMU1898@unexploded-cow.prv.splode.com>
2014-06-05 20:56 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).