From: Agustin Martin <agustin.martin@hispalinux.es>
To: Vladimir Lomov <lomov.vl@gmail.com>, 15903@debbugs.gnu.org
Subject: bug#15903: 24.3.50; Fix small issue with ispell-hunspell when dictionary is set to default (nil)
Date: Mon, 18 Nov 2013 13:11:58 +0100 [thread overview]
Message-ID: <20131118121157.GA8051@agmartin.aq.upm.es> (raw)
In-Reply-To: <20131118063300.GB889@smoon>
On Mon, Nov 18, 2013 at 03:33:00PM +0900, Vladimir Lomov wrote:
> Hello,
> ** Agustin Martin [2013-11-16 12:43:02 +0100]:
>
> > 2013/11/15 Vladimir Lomov <lomov.vl@gmail.com>
>
> >> Hello,
> >> according to variable 'ispell-dictionary-base-alist' defined in
> >> 'ispell.el' if 'ispell-dictionary' is nil then it is considered as
> >> default value for dictionary. Unfortunately, when hunspell is used as
> >> ispell program function 'ispell-parse-hunspell-affix-file' fails because
> >> it doesn't expect nil as argument.
>
> >> I propose small and simple patch. I checked it starting emacs as:
> >> emacs -Q
> >> and evaluating in *scratch*:
> >> (setq ispell-program-name "hunspell")
> >> (setq ispell-really-hunspell t)
> >> after that I run 'M-$' while point is on first 's' of
> >> (message)
>
> >> In minibuffer I see
> >> MESSAGE is correct
>
> >> Without this patch the same steps lead to message
> >> ispell-phaf: No matching entry for nil.
>
> > Hi,
>
> > Cannot reproduce it here. By the way, once initialized for hunspell
> > ispell.el provides a match for default (nil) value, here
>
> > (nil [[:alpha:]] [^[:alpha:]] ['] nil (-B) nil utf-8)
>
> Wouldn't you mind to share how you get this?
Using 20131101 emacs-snapshot,
$ LC_ALL=C emacs-snapshot -Q &
In scratch buffer, type
(setq ispell-program-name "hunspell")
(setq ispell-dictionary nil)
and `eval-region' that region. Then run 'M-$' on a couple of words (file and
dictionary). This will make ispell.el be loaded and ispell process started,
messages buffer shows
Starting new Ispell process [hunspell::default] ...
Checking spelling of FILE...
FILE is correct
Checking spelling of DICTIONARY...
DICTIONARY is correct
Evaluating in the scratch buffer
(message "%s" (assoc nil ispell-hunspell-dictionary-alist))
I get (now default here is en_US)
(nil [[:alpha:]] [^[:alpha:]] ['0-9] t (-d en_US) nil utf-8)
Note that `ispell-hunspell-dictionary-alist' is not bound until ispell.el is
loaded, and that will not happen until you spellcheck for the first time (or
call a command that forces ispell.el load), so the first part of your check
should do nothing until then. If you get some result there please doublecheck
that you are not loading it from a different site.
PS: What is prin1?
Regards,
--
Agustin
next prev parent reply other threads:[~2013-11-18 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 15:16 bug#15903: 24.3.50; Fix small issue with ispell-hunspell when dictionary is set to default (nil) Vladimir Lomov
2013-11-15 17:00 ` bug#15904: " Glenn Morris
2013-11-16 11:43 ` bug#15903: " Agustin Martin
2013-11-18 6:33 ` Vladimir Lomov
2013-11-18 12:11 ` Agustin Martin [this message]
2013-11-18 12:48 ` Vladimir Lomov
2013-11-19 10:29 ` Agustin Martin
2013-11-19 12:08 ` Vladimir Lomov
2013-11-19 13:43 ` Agustin Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118121157.GA8051@agmartin.aq.upm.es \
--to=agustin.martin@hispalinux.es \
--cc=15903@debbugs.gnu.org \
--cc=lomov.vl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).