From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Anthony Newsgroups: gmane.emacs.bugs Subject: bug#15599: [PATCH] Inferior Lisp Mode Menu Date: Tue, 22 Oct 2013 01:56:06 +0100 Message-ID: <20131022005606.GA10573@jo.hnanthony.com> References: <20131012170846.GA688@jo.hnanthony.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1382403500 14616 80.91.229.3 (22 Oct 2013 00:58:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Oct 2013 00:58:20 +0000 (UTC) Cc: 15599@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 22 02:58:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VYQIg-0003zA-0n for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2013 02:58:22 +0200 Original-Received: from localhost ([::1]:42420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYQIf-0005i2-Ng for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2013 20:58:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYQIV-0005ht-C0 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2013 20:58:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYQIM-0006P7-U8 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2013 20:58:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYQIM-0006P2-Qi for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2013 20:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VYQIM-0006ZU-59 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2013 20:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Anthony Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2013 00:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138240347325246 (code B ref -1); Tue, 22 Oct 2013 00:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2013 00:57:53 +0000 Original-Received: from localhost ([127.0.0.1]:33756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYQIC-0006Z7-P1 for submit@debbugs.gnu.org; Mon, 21 Oct 2013 20:57:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55428) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYQI9-0006Yq-W9 for submit@debbugs.gnu.org; Mon, 21 Oct 2013 20:57:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYQHw-0006M4-69 for submit@debbugs.gnu.org; Mon, 21 Oct 2013 20:57:44 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYQHw-0006Lz-1q for submit@debbugs.gnu.org; Mon, 21 Oct 2013 20:57:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYQHp-0005Fz-PZ for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2013 20:57:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYQHj-0006Kv-QN for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2013 20:57:29 -0400 Original-Received: from [198.46.132.138] (port=55179 helo=jo.hnanthony.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYQHd-0006Ij-EM; Mon, 21 Oct 2013 20:57:17 -0400 Original-Received: from jo.hnanthony.com (localhost.localdomain [127.0.0.1]) by jo.hnanthony.com (8.14.3/8.14.3/Debian-9.4) with ESMTP id r9M0u6HO010629; Tue, 22 Oct 2013 01:56:06 +0100 Original-Received: (from john@localhost) by jo.hnanthony.com (8.14.3/8.14.3/Submit) id r9M0u60o010628; Tue, 22 Oct 2013 01:56:06 +0100 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79483 Archived-At: On Fri, Oct 18, 2013 at 10:48:11PM -0400, Glenn Morris wrote: > > Thanks. Please send a reminder when you hear your copyright assignment > is complete. I'll be sure to contact you as soon as I hear back. > > ["Eval Last Sexp" lisp-eval-last-sexp t] > > Is it useful to have that appearing in the inferior lisp buffer's menu? > Surely it's normally used with stuff in a Lisp Mode buffer? This was my initial though as well, although I have used it in an inferior lisp session as well - useful for checking the last sexp you wrote will give the correct result whilst working on a larger expression. > > ["Load File" lisp-load-file t] > > Should be "Load File..." > Similarly for "Compile File...", and indeed for most of these menu items > I think. I think you're quite correct. Before deciding to work on them I, like I think most Emacs users, always hid and never thought about the menus. It's taken me a while to really grok the style and filter out the inconsistent stuff from the good. > > ["Show Fucntion Doc" lisp-show-function-documentation t] > ^^^^^^^^ > I think "Show Documentation for Function..." would be better. > But again, isn't this a command more likely to be useful in a Lisp Mode > buffer? IMO this applies to many of those menu items. > But I never use inferior-lisp-mode, so I don't know. I've taken to spell-checking whilst I work on menu entries as well. There are lots of times I've looked at things and tried to decide if it should be in the menu entry. etc/TODO says inferior-lisp should have a menu entry but all of the functions seem to be better off in a Lisp Mode buffer. I'll also resist the urge for brevity and just use a proper sentence in future - I guess it makes sense to provide menu users with an informative menu item as they are less likely to have much experience. In future I'll append "..." to menu entries that require further input in accordance with style rules. The two entries you pointed out seem to be the most useful entries, actually, as I could see myself wanting to look up documentation (especially for the last-typed function) in an inferior-lisp. As always, style and implementation feedback is extremely welcome. I'm intending to do a lot of this and therefore early feedback will prevent me from doing a lot of extra work fixing things I've done wrong. -- John Anthony