From: Alan Mackenzie <acm@muc.de>
To: Ivan Andrus <darthandrus@gmail.com>
Cc: 15211@debbugs.gnu.org
Subject: bug#15211: 24.3.50; Incorrect fontification in c++-mode
Date: Wed, 18 Sep 2013 21:19:56 +0000 [thread overview]
Message-ID: <20130918211956.GC5640@acm.acm> (raw)
In-Reply-To: <143319A4-5908-4B0C-9B33-D3AA59142260@gmail.com>
Hi, Ivan.
On Tue, Sep 10, 2013 at 02:04:31PM -0600, Ivan Andrus wrote:
> On Aug 31, 2013, at 2:56 PM, Alan Mackenzie <acm@muc.de> wrote:
> > The following patch disables the distinction and always fontifies the
> > identifier. Please try it out and let me know if any undesirable
> > side effects occur, or if it doesn't quite fix the problem in real
> > code:
> I have been using your diff below for a few days, and I haven't noticed
> any negative side effects.
Thanks. I've committed the patch to the bazaar repository and marked the
bug as closed.
> There are still two things that don't fontify correctly:
> #define DELETE_MEMBER = delete
> class Bob
> {
> Bob &operator=(Bob const &) = delete; // fontified (with diff applied)
> Bob &operator=(Bob const &) DELETE_MEMBER; // not fontified with or without diff
> Bob( string ); // string is a `font-lock-type-face'
> explicit Bob( string ); // string is `font-lock-variable-name-face'
> };
> The first bad fontification seems to be caused because it doesn't
> understand the macro which probably can't be helped.
I think so. Though I don't understand what the "= delete;" bit means
(I'm not a C++ hacker).
> The second though is a bit more concerning, though it seems to be
> unrelated to the current bug. I will probably open another bug for it
> unless you'd prefer I didn't
I'd rather you did open a separate bug, please. As a matter of interest,
in "Bob( string );" (without the "explicit"), I don't get either
identifier fontified.
> Thanks again,
> Ivan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2013-09-18 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 20:48 bug#15211: 24.3.50; Incorrect fontification in c++-mode Ivan Andrus
2013-08-31 20:56 ` Alan Mackenzie
2013-09-10 20:04 ` Ivan Andrus
2013-09-18 21:19 ` Alan Mackenzie [this message]
2013-09-19 3:33 ` Ivan Andrus
2013-09-18 20:53 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918211956.GC5640@acm.acm \
--to=acm@muc.de \
--cc=15211@debbugs.gnu.org \
--cc=darthandrus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).