unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: PV <frerot13@gmail.com>
To: 14041@debbugs.gnu.org
Subject: bug#14041: XTring_bell() does not work in some Linux distributions
Date: Sat, 23 Mar 2013 11:38:37 +0100	[thread overview]
Message-ID: <201303231138.37230.frerot13@gmail.com> (raw)

Hi,

In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000

The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
but the function gdk_beep() is not,
thus I suggest to modify XTring_bell () in xterm.c in the following way:


/* Make audible bell.  */

void
XTring_bell ()
{
  struct frame *f = SELECTED_FRAME ();

  if (FRAME_X_DISPLAY (f))
    {
#if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
      if (visible_bell)
	XTflash (f);
      else
#endif
	{
	  BLOCK_INPUT;
#ifdef USE_GTK           	     // P.VINCENT
	  gdk_beep ();   	     // P.VINCENT
#else			 	     // P.VINCENT
	  XBell (FRAME_X_DISPLAY (f), 0);
	  XFlush (FRAME_X_DISPLAY (f));
#endif                   	     // P.VINCENT
	  UNBLOCK_INPUT;
	}
    }
}

Best regards,
Patrick VINCENT





             reply	other threads:[~2013-03-23 10:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 10:38 PV [this message]
2013-03-25 18:01 ` bug#14041: XTring_bell() does not work in some Linux distributions Jan Djärv
2013-03-26 13:07   ` Petr Hracek
2013-03-26 14:52     ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303231138.37230.frerot13@gmail.com \
    --to=frerot13@gmail.com \
    --cc=14041@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).